Closed Arke64 closed 6 years ago
Could you have a constructor signature that matches
https://github.com/lancaster-university/codal-core/blob/master/inc/drivers/LIS3DH.h#L119
We've updated it. Before I make another tag, will you need the display signature to take an I2C object instead of SCL and SDA pins as well?
Yes, constructor signature should be the same as LIS3DH
From: John Brochue notifications@github.com Sent: Friday, April 20, 2018 8:46:24 AM To: Microsoft/pxt-brainpad Cc: Peli de Halleux; Assign Subject: Re: [Microsoft/pxt-brainpad] codal v0.0.11 (#56)
We've updated it. Before I make another tag, will you need the display signature to take an I2C object instead of SCL and SDA pins as well?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-brainpad%2Fissues%2F56%23issuecomment-383138405&data=02%7C01%7Cjhalleux%40microsoft.com%7Ce948ae6e85f947d6ef5008d5a6d5df4a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636598359864990112&sdata=UKhaOZWbV%2B60ZrkNHpOsbq7dRUluq32KICPheyD5rPA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KegQhUpH1t-08_1W74UaJX2SfIsYks5tqgLQgaJpZM4TcQCj&data=02%7C01%7Cjhalleux%40microsoft.com%7Ce948ae6e85f947d6ef5008d5a6d5df4a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636598359864990112&sdata=AblRRuWLKCSbKgqoKn8tOM%2FISEnh9oJ2Eiq8Ce%2FbOTg%3D&reserved=0.
Sorry, I meant our BrainPadDisplay class. We've already updated our MMA8453 to match the LIS3DH. The display takes two pins and not an I2C object.
Can you give me a tag with https://github.com/ghi-electronics/codal-brainpad/commit/bd29d99353ce0161b44122e5d5f28cbf7f3b5973 ?
@Arke64 I need a tag in order to be able to use those updates.
Sorry about the delay: https://github.com/ghi-electronics/codal-brainpad/tree/v0.0.12
I noticed our signature uses codal::_mbed::I2C
while the LIS3DH uses codal::I2C
. We're working on getting that updated right now.
I'll wait for the new signature.
https://github.com/ghi-electronics/codal-brainpad/tree/v0.0.13
We're still working on figuring out which concrete implementation of codal::I2C
to use in model/BrainPad.h
though.
@pelikhan pinging as requested
Merged.
We've got the latest code up at https://github.com/ghi-electronics/codal-brainpad/releases/tag/v0.0.11
Adds what should be properly scaled light, temperature, and accelerometer along with light and temperature being abstracted into their own classes.