microsoft / pxt-brainpad

Microsoft MakeCode editor for the GHI Brainpad
https://makecode.brainpad.com/
Other
3 stars 11 forks source link

255 vs 100%? #65

Closed greg-norris closed 6 years ago

greg-norris commented 6 years ago

There are several places where users can enter parameters. Such as the "set brightness" block, and the "Colors: red, green, and blue parameter" block. Are the we going to be using the values of '0 - 255' or '0 - 100%' going forward?

We ask this question for two reasons, we want to get our supplemental documentation correct, and we've come across this issue several times in the past. We've had this issue when trying to explain to students, that are new to programming, what these values actually mean. In particular when we refer to things like 'set brightness'. They always assume 0 - 100%. We've found 255 means nothing to new programmers and often can be confusing to them.

pelikhan commented 6 years ago

Those ranges are correct. We discovered that it made it easier to pipe sensor data - like light level - into colors. We do have custom data pickers for those and we could render a “(100%)” next to the value in those.

All the API in brainpad are shared with other editors like Adafruit so changing them requires careful thinking. On the other hand, you benefit from shared documentation and localization


From: greg-norris notifications@github.com Sent: Monday, May 7, 2018 8:16 AM Subject: [Microsoft/pxt-brainpad] 255 vs 100%? (#65) To: Microsoft/pxt-brainpad pxt-brainpad@noreply.github.com Cc: Subscribed subscribed@noreply.github.com

There are several places where users can enter parameters. Such as the "set brightness" block, and the "Colors: red, green, and blue parameter" block. Are the we going to be using the values of '0 - 255' or '0 - 100%' going forward?

We ask this question for two reasons, we want to get our supplemental documentation correct, and we've come across this issue several times in the past. We've had this issue when trying to explain to students, that are new to programming, what these values actually mean. In particular when we refer to things like 'set brightness'. They always assume 0 - 100%. We've found 255 means nothing to new programmers and often can be confusing to them.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-brainpad%2Fissues%2F65&data=02%7C01%7Cjhalleux%40microsoft.com%7C71f241916f4f40f1605508d5b42d708f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636613029610621400&sdata=gTPHmmqKGyNYSavv5nR%2Fr4YePaZ%2B1la%2FH4tuE7bQ0cI%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KT9MzeXt5lJE7HWYz6PZo23SLhPQks5twGUugaJpZM4T1JcR&data=02%7C01%7Cjhalleux%40microsoft.com%7C71f241916f4f40f1605508d5b42d708f%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636613029610621400&sdata=XAgQ5xMGk0PZ2f%2BKwAb4xTRs79zOMWB%2BwDbT31G5VGE%3D&reserved=0.

pelikhan commented 6 years ago

@samelhusseini can we render value (percent) in the range field editor?