microsoft / pxt-brainpad

Microsoft MakeCode editor for the GHI Brainpad
https://makecode.brainpad.com/
Other
3 stars 11 forks source link

music.playTone block default value. #85

Closed greg-norris closed 6 years ago

greg-norris commented 6 years ago

The default value when dragging in the music.playTone block is showing part of the function.

playtone

There appears to be two calls to music.beat() when I look at the Javascript.

forever(function () { music.playTone(262, music.beat(music.beat(BeatFraction.Half))) })

https://makecode.com/_9rLUsTA5WRDF

pelikhan commented 6 years ago

Is this still the case in /beta?


From: greg-norris notifications@github.com Sent: Monday, May 21, 2018 5:32 AM Subject: [Microsoft/pxt-brainpad] music.playTone block default value. (#85) To: Microsoft/pxt-brainpad pxt-brainpad@noreply.github.com Cc: Subscribed subscribed@noreply.github.com

The default value when dragging in the music.playTone block is showing part of the function.

[playtone]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F29868099%2F40307456-9badde34-5cd0-11e8-8181-860f7782e064.jpg&data=02%7C01%7Cjhalleux%40microsoft.com%7C08fa57f934be46af519e08d5bf16cfa8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636625027051972975&sdata=09Fj6ormx%2FAZK4xfggomPHtZ0w%2FXCo%2BMOAvc9WeOCJc%3D&reserved=0

There appears to be two calls to music.beat() when I look at the Javascript.

forever(function () { music.playTone(262, music.beat(music.beat(BeatFraction.Half))) })

https://makecode.com/_9rLUsTA5WRDFhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmakecode.com%2F_9rLUsTA5WRDF&data=02%7C01%7Cjhalleux%40microsoft.com%7C08fa57f934be46af519e08d5bf16cfa8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636625027051972975&sdata=vEjBN3keN%2FOAA3zXbJkKWN31xERMQc3wGlURWuoxtIE%3D&reserved=0

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-brainpad%2Fissues%2F85&data=02%7C01%7Cjhalleux%40microsoft.com%7C08fa57f934be46af519e08d5bf16cfa8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636625027052129229&sdata=MVXoZeoSwItJqcpH8yNQ%2BYBP8E%2ByNf0auGYzxgT3ItA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KfJuBnvkF-_uOB8mD0PXegfgP9G0ks5t0rOvgaJpZM4UG6mz&data=02%7C01%7Cjhalleux%40microsoft.com%7C08fa57f934be46af519e08d5bf16cfa8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636625027052129229&sdata=bpvmSutRt%2F7bfpQNDmuclsJnXySaSIvn6VxtMhOCebY%3D&reserved=0.

greg-norris commented 6 years ago

Yes, same in beta.