Closed greg-norris closed 6 years ago
This may be the issue. Is this change making it to the live website?
https://github.com/lancaster-university/codal-mbedos/commit/c7a41da3a3b9ae109857516b8e615d4bf8198db7
Locally it's working fine.
This is not how it works. You need to bump pxt-brainpad, then update index-ref with that version. I will update the readme.
Okay cool, should change and submit a new pr to fix?
From: greg-norris notifications@github.com Sent: Friday, May 25, 2018 7:08 AM Subject: [Microsoft/pxt-brainpad] bumping codal target and index-ref.json (#91) To: Microsoft/pxt-brainpad pxt-brainpad@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com, Assign assign@noreply.github.com
Okay cool, should change and submit a new pr to fix?
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-brainpad%2Fissues%2F91%23issuecomment-392069462&data=02%7C01%7Cjhalleux%40microsoft.com%7Cd5b4d8b4fb1f40cd46c608d5c248ed07%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636628540828618793&sdata=VfSQe%2B4vEi%2FUv%2FNnlvR%2FnMZ%2BRX7oCC32xj9cRGfXcaw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KfJHHnqPZdp1yI3DGT7_CMNkunmBks5t2BBBgaJpZM4UN3fM&data=02%7C01%7Cjhalleux%40microsoft.com%7Cd5b4d8b4fb1f40cd46c608d5c248ed07%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636628540828628802&sdata=wqAxA6dFS7rYH%2B51N0N3p2BoN3SWlpokrSWWdD%2B5QNU%3D&reserved=0.
Awesome, thanks for clearing that up. Will fix.
I bumped yesterday. so v0.20.66 is the latest tag. Always check that everything works in beta.
Updated.
Thanks, works perfectly!
We bumped the codal target version to link to our changes https://github.com/Microsoft/pxt-brainpad/commit/fb95de6294afb1c9f6bec6b1f017ecba0cd623a2 , and the index-ref.json to make the beta live https://github.com/Microsoft/pxt-brainpad/commit/da7ae77a5935a6caa663bbcd30c195dd4aa7a570
is there anything else that has to be changed? Because the display works when I download a fresh install of the current pxt-brainpad and run it locally, but it doesn't work at https://makecode.brainpad.com/ or the beta site. Maybe there's something I'm missing in the steps.
https://makecode.com/_CUMdUWU7LhV1