microsoft / pxt-calliope

A Microsoft MakeCode editor for the Calliope Mini board
https://makecode.calliope.cc
Other
39 stars 22 forks source link

fix case in path #285

Closed Amerlander closed 4 months ago

Amerlander commented 4 months ago

This time, there's a snag, the CI was failing because the case of the icon path was wrong.

@abchatra could you merge this fix and bump. I'm sorry for that mistake.

Amerlander commented 4 months ago

@abchatra the CI still fails. This time it seems to be an issue within Crowdin: Requested project doesn't exist or the API key is invalid

executing Crowdin command upload...
upload calliopemini/target-strings.json (60 strings) to https://crowdin.com/project/makecode
INTERNAL ERROR: Error: Error, upload translation: calliopemini/target-strings.json, 404, {
    "success": false,
    "error": {
        "code": 1,
        "message": "Requested project doesn't exist or the API key is invalid"
    }
}

I'm not sure where to fix this, can you take a look?

abchatra commented 4 months ago

@riknoll help please

riknoll commented 4 months ago

@Amerlander we recently upgraded to using crowdin's v2 APIs because crowdin finally shut down their v1 APIs. I've opened a PR to cherry pick the changes over to the version of pxt-core you're using:

https://github.com/microsoft/pxt/pull/9991

Once that is merged, you'll want to update the pxt-core version you have in package.json to get the new crowdin changes

riknoll commented 4 months ago

@Amerlander should be fixed now. Make sure to merge master!

riknoll commented 4 months ago

eh, actually looks like it's uploading now but it has hit a snag with one of the filenames. i'll investigate

riknoll commented 4 months ago

fixed and bumped!