add examples for chapter 4

bunnie commented 7 years ago

Hi, this should be the three examples we need to have added for chapter 4. I hope I did it right.

msftclas commented 7 years ago

All CLA requirements met.

samelhusseini commented 7 years ago

PR looks good @bunnie.

A couple things:

Need to sign the CLA apparently. (Edit: All sorted now)
In order to add the cards to the home screen, you'll need to edit examples.md (which is essentially an authoring file for home screen cards): https://github.com/Microsoft/pxt-chibitronics/blob/master/docs/examples.md In that file you'd set the name on the card you want to use, a url to it and an optional image.
Which brings me to my next point, are there any images we can associate with these examples? thus far we've just been taking a GIF of the simulated output. Not a huge fan of that and I'm looking for any ideas you might have about that.

bunnie commented 7 years ago

I think I did a new PR wrong to merge in a commit that edits examples.md:

https://github.com/Microsoft/pxt-chibitronics/pull/123/commits/7504e7e9c70ab4465e30c3f4da94156981698284

I signed the CLA.

Also, for the images, this coming December I have an intern coming in who will make demos of these and hopefully we can have a more compelling mini-video. It will just take some time. In the meantime, could you just render a GIF for these as a placeholder?

thanks,

-b.

On 11/22/2017 02:20 PM, Sam El-Husseini wrote:

PR looks good @bunnie https://github.com/bunnie.

A couple things:

Need to sign the CLA apparently.

In order to add the cards to the home screen, you'll need to edit examples.md (which is essentially an authoring file for home screen cards): https://github.com/Microsoft/pxt-chibitronics/blob/master/docs/examples.md In that file you'd set the name on the card you want to use, a url to it and an optional image.

Which brings me to my next point, are there any images we can associate with these examples? thus far we've just been taking a GIF of the simulated output. Not a huge fan of that and I'm looking for any ideas you might have about that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/pxt-chibitronics/pull/122#issuecomment-346254677, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHT9yNfh8HPXXNjJpm2G8bUcE-aF33wks5s470ggaJpZM4Qm5WC.

-- ^'~*-,._.^'~-,._.^`'~-,..^`'~*-,..^'~*-,._.^'~-,._.^`'~-,._.^`'

samelhusseini commented 7 years ago

All sorted. Changes are live: https://makecode.chibitronics.com/examples

From: bunnie notifications@github.com Sent: Tuesday, November 21, 2017 10:51:38 PM To: Microsoft/pxt-chibitronics Cc: Sam El-Husseini; Comment Subject: Re: [Microsoft/pxt-chibitronics] add examples for chapter 4 (#122)