search

microsoft / pxt-chibitronics

Chibitronics Love To Code board editor with Microsoft MakeCode
https://makecode.chibitronics.com
Other
23 stars 15 forks source link

Add chapter 3 example #139

Closed bunnie closed 6 years ago

bunnie commented 6 years ago

This is the example referred to in chapter 3.

Chapter 3 is now available for download, fwiw.

pelikhan commented 6 years ago

You could also add a category that points to the chapter downloads. It is possible to setup a card as an external URL.

bunnie commented 6 years ago

ooh, that would be excellent! do you have an example of a card that does that?

thanks,

-b.

On December 26, 2017 12:09:37 AM GMT+08:00, Peli de Halleux notifications@github.com wrote:

You could also add a category that points to the chapter downloads. It is possible to setup a card as an external URL.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/Microsoft/pxt-chibitronics/pull/139#issuecomment-353878019

samelhusseini commented 6 years ago

Yep. https://github.com/Microsoft/pxt-adafruit/blob/master/docs/learnsystem.md (note the url field)

bunnie commented 6 years ago

OK! I've tried adding some cards that point to docs. I think theoretically it looks great in markdown but we'll see how this looks aesthetically and user-experiencely.

I'm using tslint now, so hopefully fewer stupid errors in the pull requests.

bunnie commented 6 years ago

hrm. the build still broke, but i can't find the bug. sorry about that :( wonder what i did wrong this time...

pelikhan commented 6 years ago

Try rubbing “pxt checkdocs —snippets”. The error is 

USER ERROR: 1 snippets not compiling in the docs

04:57:05 npm ERR! Test fa

bunnie commented 6 years ago

thanks, the error output by the tool was pretty opaque but at least it flagged the file where the problem was. hopefully this last commit fixes it.

I get a lot of spew when i run pxt checkdock --snippets, looks like this:

/reference/lights/set-0:(0,undefined): 1 Cannot read file 'no-default-lib.d.ts': File not found: no-default-lib.d.ts /reference/lights/set-0:(0,undefined): 1 Cannot find global type 'Array'. /reference/lights/set-0:(0,undefined): 1 Cannot find global type 'Boolean'. /reference/lights/set-0:(0,undefined): 1 Cannot find global type 'Function'.

is this normal?

samelhusseini commented 6 years ago

Yeah we're aware of that issue. @riknoll is looking into it.

samelhusseini commented 6 years ago

FYI these links won't work until we push the latest release which included support for custom urls. I've prepared a PR: https://github.com/Microsoft/pxt-chibitronics/pull/137 for the release, just waiting for a final sign off from someone at Chibitronics