microsoft / pxt-chibitronics

Chibitronics Love To Code board editor with Microsoft MakeCode
https://makecode.chibitronics.com
Other
23 stars 15 forks source link

Cannot compile on IE11 #180

Closed guillaumejenkins closed 6 years ago

guillaumejenkins commented 6 years ago

[IE11] Even an empty project doesn't compile:

image

I can't open the F12 tools to check the error, my browser crashes. This happens on the live website too

pelikhan commented 6 years ago

image

pelikhan commented 6 years ago

@bunnie looks like getRawWavData is dereferencing samples instead of rawPcmData.

abchatra commented 6 years ago

@xobs Can you take a peek? This is a blocking bug in IE11.

bunnie commented 6 years ago

Hi Sean,

Can you look into this one - this is the mystery "Compiler Error Please ContacT Support" we received the other day through our other customer support channel. It was in MakeCode apparently!

-b.

On 02/10/2018 02:01 AM, Peli de Halleux wrote:

@bunnie https://github.com/bunnie looks like getRawWavData is dereferencing |samples| instead of |rawPcmData|.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Microsoft/pxt-chibitronics/issues/180#issuecomment-364510427, or mute the thread https://github.com/notifications/unsubscribe-auth/ABHT9-Xh65tLryhzu5LxOJVwwMoefUjAks5tTIgBgaJpZM4SASN9.

-- ^'~*-,._.^'~-,._.^`'~-,..^`'~*-,..^'~*-,._.^'~-,._.^`'~-,._.^`'

xobs commented 6 years ago

I've updated ltc-npm-modulate to 1.2.1, which fixes this issue

pelikhan commented 6 years ago

https://github.com/Microsoft/pxt-chibitronics/pull/186

pelikhan commented 6 years ago

Fix in beta