abchatra
commented
6 years ago Also see unplugged text at the top of the documentation.
Open abchatra opened 6 years ago
abchatra
commented
6 years ago Also see unplugged text at the top of the documentation.
samelhusseini
commented
6 years ago Print doesnt support background color of span.
Thats a browser feature, I think its fine since it shows the color as a border, and the text is legible.
From: Abhijith Chatra notifications@github.com Sent: Wednesday, June 20, 2018 5:58:11 PM To: Microsoft/pxt-ev3 Cc: Subscribed Subject: [Microsoft/pxt-ev3] Print in documentation doesn't render the blocks correctly (#718)
To Reproduce Steps to reproduce the behavior:
Desktop (please complete the following information):
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-ev3%2Fissues%2F718&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C82ad9ee0f00642eb602e08d5d7121032%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651394936673191&sdata=uAwGQq8SQqQBWYOjqkx56UjmsLL5ndsPmriX4YyPkEw%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP6rzF8ZfUuxAduNwUE_-YdO6ShlnX5iks5t-u-jgaJpZM4UxFme&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C82ad9ee0f00642eb602e08d5d7121032%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651394936683205&sdata=msfmtpxe8Y0B02VlfR19Zz3VXP7sVQgtEUuV6Pudvw4%3D&reserved=0.
samelhusseini
commented
6 years ago @pelikhan was working on a PR for the cloud to discard these @ tags from the rendered markdown.
From: Abhijith Chatra notifications@github.com Sent: Wednesday, June 20, 2018 5:58:57 PM To: Microsoft/pxt-ev3 Cc: Subscribed Subject: Re: [Microsoft/pxt-ev3] Print in documentation doesn't render the blocks correctly (#718)
Also see unplugged text at the top of the documentation.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-ev3%2Fissues%2F718%23issuecomment-398943340&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C4989b6b68ecd4480762f08d5d7122bb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651395980355177&sdata=7iizLlvOozGc0zcifZgVbxwjmMBhX7sNUo%2B8yNxZg8U%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP6rzHtkxLjTBxZ4JOdFns5HbhoP4lMxks5t-u_RgaJpZM4UxFme&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C4989b6b68ecd4480762f08d5d7122bb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651395980355177&sdata=IyuLh0SOtpbSgQLRSOqKPYypLcdpgFN0wbFT%2FT95VqM%3D&reserved=0.
pelikhan
commented
6 years ago It needs to be pushing in the cloud.
From: Sam El-Husseini notifications@github.com Sent: Wednesday, June 20, 2018 6:01 PM To: Microsoft/pxt-ev3 Cc: Peli de Halleux; Mention Subject: Re: [Microsoft/pxt-ev3] Print in documentation doesn't render the blocks correctly (#718)
@pelikhan was working on a PR for the cloud to discard these @ tags from the rendered markdown.
From: Abhijith Chatra notifications@github.com Sent: Wednesday, June 20, 2018 5:58:57 PM To: Microsoft/pxt-ev3 Cc: Subscribed Subject: Re: [Microsoft/pxt-ev3] Print in documentation doesn't render the blocks correctly (#718)
Also see unplugged text at the top of the documentation.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-ev3%2Fissues%2F718%23issuecomment-398943340&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C4989b6b68ecd4480762f08d5d7122bb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651395980355177&sdata=7iizLlvOozGc0zcifZgVbxwjmMBhX7sNUo%2B8yNxZg8U%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAP6rzHtkxLjTBxZ4JOdFns5HbhoP4lMxks5t-u_RgaJpZM4UxFme&data=02%7C01%7CSam.El-Husseini%40microsoft.com%7C4989b6b68ecd4480762f08d5d7122bb4%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651395980355177&sdata=IyuLh0SOtpbSgQLRSOqKPYypLcdpgFN0wbFT%2FT95VqM%3D&reserved=0.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fpxt-ev3%2Fissues%2F718%23issuecomment-398943651&data=02%7C01%7Cjhalleux%40microsoft.com%7Ce78dca88351f44b8038808d5d7127837%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651396684699953&sdata=uY%2BRSPWX%2BMtfqb%2B0MSKLKP9rdsdPFddpl4n5RS7N3a4%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAD-4KaO55h6lKwTE4fr8lIcWfTJaGQV0ks5t-vBSgaJpZM4UxFme&data=02%7C01%7Cjhalleux%40microsoft.com%7Ce78dca88351f44b8038808d5d7127837%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636651396684709965&sdata=Hlu%2FQPYNR6gzajlNU%2Bje5k60QYHExgspjDs3H90zwn8%3D&reserved=0.
pelikhan
commented
6 years ago Right printing the color background is unreadable. This is by design.
abchatra
commented
6 years ago Ok removed release
abchatra
commented
6 years ago I will keep the bug open for tracking Unplugged
pelikhan
commented
6 years ago This change needs to make it in the docs. https://github.com/Microsoft/pxt/blob/234562f7c49c8c1dc8c81a90b9fc931930731bcc/pxtlib/docsrender.ts#L390
To Reproduce Steps to reproduce the behavior:
Screenshots
Desktop (please complete the following information):