search

microsoft / pxt-maker

MakeCode target for "Maker" boards (beta)
https://maker.makecode.com/
Other
116 stars 82 forks source link

files for adafruit grand central #329

Closed guriaregojo closed 3 years ago

guriaregojo commented 3 years ago

Here are the files

guriaregojo commented 3 years ago

https://github.com/microsoft/pxt-common-packages/pull/1207/commits/98fec207605b64939f41dc63cfdafa33c14f88af

guriaregojo commented 3 years ago

Are there any more files that need to be modified in common packages?

pelikhan commented 3 years ago

There's a comment on that PR that needs to be addressed https://github.com/microsoft/pxt-common-packages/pull/1207#discussion_r555795077

guriaregojo commented 3 years ago

Hi @pelikhan @mmoskal could you get back to this? I really want to get the grand central in...

wallarug commented 3 years ago

Hey everyone on this ticket.

What extra steps need to be taken to have this pushed through? What is the microsoft makecode team waiting on?

Thanks

pelikhan commented 3 years ago

It’s live please test

From: wallarug notifications@github.com Sent: Tuesday, March 2, 2021 11:33:01 AM To: microsoft/pxt-maker pxt-maker@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Mention mention@noreply.github.com Subject: Re: [microsoft/pxt-maker] files for adafruit grand central (#329)

Hey everyone on this ticket.

What extra steps need to be taken to have this pushed through? What is the microsoft makecode team waiting on?

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-maker%2Fpull%2F329%23issuecomment-788805383&data=04%7C01%7Cjhalleux%40microsoft.com%7C1cad1fcb23ff4f73edc408d8dd668e2b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502779839222788%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=chIQHE%2B3r9wvHpPNR4pSpFZVvfDSBa5ZJT0PxQPZ%2FLU%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKLX4VQOULKI7AYXUJLTBS5F3ANCNFSM4WI62ILQ&data=04%7C01%7Cjhalleux%40microsoft.com%7C1cad1fcb23ff4f73edc408d8dd668e2b%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637502779839232781%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Fjw0iXY%2FLBr0CgEpr%2Fg8vUG%2Bj%2FvD0QhQwad1%2B0pXLqA%3D&reserved=0.

guriaregojo commented 3 years ago

great! seems to be working thanks