search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
715 stars 588 forks source link

Content that does not work in Windows offline use of Electron app #3238

Open kimprice opened 4 years ago

kimprice commented 4 years ago

There is a lot of content that either does not work offline or points to documentation which has embedded videos that require internet connectivity.

This list is not exhaustive: Nothing (perhaps unsurprisingly) in the Live Coding section works. In Games section, Reaction Time brings user to local copy of webpage with video that cannot be displayed without internet connection, same with Magic Button Trick, same with Salute. The documentation for these seems thorough enough that a user would still be able to complete the project. Nothing in the Turtle section works without internet. See screenshots below after clicking on the Scanner project. Some content in the Science section also heavily relies on videos for instruction - see screenshot below which is from the Plant Watering project. In the Music section, the Guitar project leads to documentation with many embedded videos for instruction, which does not seem usable at all without internet.

Expected behavior It should be more obvious to the user what content requires internet connectivity or is optimal with internet connectivity. If a tutorial (like the Scanner project) is unavailable without internet, it should not create a project in the workspace.

Screenshots Add screenshots to help explain your problem. You can copy paste the screenshot in the github report. The .gif screen recording is very useful as well. image image image

Desktop (please complete the following information): Windows Offline - Electron App

Jaqster commented 4 years ago

Can we somehow detect connectivity, and then grey-out the content on the Home Page that requires a connection (videos, etc.)?

Also, I think we should make sure all the Tutorials and Reference docs are packaged offline.

pelikhan commented 4 years ago

You do detection for YouTube.

From: Jacqueline Russell notifications@github.com Sent: Friday, June 5, 2020 2:14:42 PM To: microsoft/pxt-microbit pxt-microbit@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [microsoft/pxt-microbit] Content that does not work in Windows offline use of Electron app (#3238)

Can we somehow detect connectivity, and then grey-out the content on the Home Page that requires a connection (videos, etc.)?

Also, I think we should make sure all the Tutorials and Reference docs are packaged offline.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-microbit%2Fissues%2F3238%23issuecomment-639822640&data=02%7C01%7Cjhalleux%40microsoft.com%7C083ad8da68664cd1f59b08d8099576ee%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637269884832669952&sdata=xKX5XTj5E5BuSicyxK3cjiJHCjS7YOFldX1%2BaVnhSO8%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKML64QWHM7SXJDHRP3RVFN4FANCNFSM4NVFJRHA&data=02%7C01%7Cjhalleux%40microsoft.com%7C083ad8da68664cd1f59b08d8099576ee%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637269884832679949&sdata=MvODqJVxUitX4cKsxuPZGdbriX6gvCiNtre%2BIMRQd58%3D&reserved=0.