search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
710 stars 586 forks source link

Simulator restarts in the background when stopped #3413

Closed pelikhan closed 3 years ago

pelikhan commented 3 years ago

Notice how the overlay shows that the simulator should be stopped; but indeed it has been restarted in the background. bug

abchatra commented 3 years ago

How do I repro this?

jwunderl commented 3 years ago

Had this one happen too; it's not in /stable, it's off master, so not this release probably. If you do a local build based off master in pxt/-microbit/-common-packages, load this https://makecode.microbit.org/_Ly6bpj357afF, and stop the sim you'll see it

jwunderl commented 3 years ago

Will need to fix this, looks like it's https://github.com/microsoft/pxt/pull/7509 -- no messages are getting posted at all except broadcast ones. It's also breaking the mute button, which is testing another change I'm making hard, so I'll take a look~

and probably https://github.com/microsoft/pxt-arcade/issues/2460 and https://github.com/microsoft/pxt-arcade/issues/2459

pelikhan commented 3 years ago

Oops. The problem is that we are routing every message including things like react debugger messages etc... you can revert it and I’ll work another fix.

From: Joey Wunderlich notifications@github.com Sent: Wednesday, October 14, 2020 8:08:20 PM To: microsoft/pxt-microbit pxt-microbit@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Author author@noreply.github.com Subject: Re: [microsoft/pxt-microbit] Simulator restarts in the background when stopped (#3413)

Will need to fix this, looks like it's microsoft/pxt#7509https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt%2Fpull%2F7509&data=04%7C01%7Cjhalleux%40microsoft.com%7Ca4d611dfdc344beda8c108d8706c22c0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637382957020285860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=ZxHjKKzxE94m1752Hwveyx6pr0pTmP8GEocDf4HwAs8%3D&reserved=0 -- no messages are getting posted at all except broadcast ones. It's also breaking the mute button, which is testing another change I'm making hard, so I'll take a look~

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-microbit%2Fissues%2F3413%23issuecomment-708571193&data=04%7C01%7Cjhalleux%40microsoft.com%7Ca4d611dfdc344beda8c108d8706c22c0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637382957020285860%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qtPU%2BgkeJxPuCYmSZPaRDUdMP3sGGBjtRy79t5cgueQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKM6NGBK5LCY3R2QRBLSKXSJJANCNFSM4SOIFHTQ&data=04%7C01%7Cjhalleux%40microsoft.com%7Ca4d611dfdc344beda8c108d8706c22c0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637382957020295851%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q6HTC8MYxZfH8kj9E%2B1A6OWc50aZNdgAhC4iGO6SCkM%3D&reserved=0.