search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
724 stars 593 forks source link

Change on-board speaker to built-in speaker for translatabiliy/clarity #3600

Closed jaustin closed 4 years ago

jaustin commented 4 years ago

It seems 'on-board' is less clear to translate from English to other langauges than 'built-in', and the effect in English is pretty similar so we prefer 'built-in' for the speaker block and API

image

--> set built-in spekaer <on/off>

setOnBoardSpeakerEnabled --> setBuiltInSpeakerEnabled

pelikhan commented 4 years ago

What about not putting this adjective?

From: Jonathan Austin notifications@github.com Sent: Thursday, November 5, 2020 6:02:38 PM To: microsoft/pxt-microbit pxt-microbit@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [microsoft/pxt-microbit] Change on-board speaker to built-in speaker for translatabiliy/clarity (#3600)

It seems 'on-board' is less clear to translate from English to other langauges than 'built-in', and the effect in English is pretty similar so we prefer 'built-in' for the speaker block and API

[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F147113%2F98272040-873f0680-1f88-11eb-91db-17342dddbfb3.png&data=04%7C01%7Cjhalleux%40microsoft.com%7Cad4b294cb32c4758028a08d881ac9a02%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401925606523708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2F0LjI9vNeXQxTGWLRE%2FRYQ8z9uCtSA7Q0Bapg4gkKc%3D&reserved=0

--> set built-in spekaer

setOnBoardSpeakerEnabled --> setBuiltInSpeakerEnabled

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-microbit%2Fissues%2F3600&data=04%7C01%7Cjhalleux%40microsoft.com%7Cad4b294cb32c4758028a08d881ac9a02%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401925606533708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=SY2Bbahc30hRx%2BGXnXEKYN%2BRsmKlUZh69fiB%2BzbZatY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKKOSDRT4EYS4TEKR3TSOLLC5ANCNFSM4TLT5DFQ&data=04%7C01%7Cjhalleux%40microsoft.com%7Cad4b294cb32c4758028a08d881ac9a02%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401925606533708%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=grlNfimbBDYbF1q2hU8yZZHXEg1a5wICZnrfmZ72VPs%3D&reserved=0.

jaustin commented 4 years ago
image

We've got some differing precedents there. I think I prefer keeping 'set' but marginally.

pelikhan commented 4 years ago

I meat remove « builtin » or « on board »

From: Jonathan Austin notifications@github.com Sent: Thursday, November 5, 2020 6:12:56 PM To: microsoft/pxt-microbit pxt-microbit@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Comment comment@noreply.github.com Subject: Re: [microsoft/pxt-microbit] Change on-board speaker to built-in speaker for translatabiliy/clarity (#3600)

[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F147113%2F98273309-054fdd00-1f8a-11eb-8ecb-c3c46ef55deb.png&data=04%7C01%7Cjhalleux%40microsoft.com%7C3069f1cf3214404f838608d881ae09dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401931777918379%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=krZwzityPOAKuu7zFcoMNH6oieAdGxaZz1qu4ZZvuUE%3D&reserved=0

We've got some differing precedents there. I think I prefer keeping 'set'

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-microbit%2Fissues%2F3600%23issuecomment-722514107&data=04%7C01%7Cjhalleux%40microsoft.com%7C3069f1cf3214404f838608d881ae09dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401931777923372%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=67RR1SYpBmjHiRz4ha3rfYJXNeMpHpvXLj%2BRL4wMEpg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKJY2VIRA4TILUA5ITLSOLMJRANCNFSM4TLT5DFQ&data=04%7C01%7Cjhalleux%40microsoft.com%7C3069f1cf3214404f838608d881ae09dc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401931777928360%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=puXFFLuJzphI2pg2ht4bSQrraOa7jBQ9dmpqOa3jFBI%3D&reserved=0.

jaustin commented 4 years ago

We don't wan't people to think this will apply to a connected speaker via an accessory. IE this will still make sound via P0 so we think 'built-in' is clearer. Lots of accessories/robots etc have speakers.

pelikhan commented 4 years ago

I think onboard or builtin is the same in terms of translation since it is not going to be translated literally.

From: Jonathan Austin notifications@github.com Sent: Thursday, November 5, 2020 6:18:32 PM To: microsoft/pxt-microbit pxt-microbit@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Comment comment@noreply.github.com Subject: Re: [microsoft/pxt-microbit] Change on-board speaker to built-in speaker for translatabiliy/clarity (#3600)

We don't wan't people to think this will apply to a connected speaker via an accessory. IE this will still make sound via P0 so we think 'built-in' is clearer. Lots of accessories/robots etc have speakers.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-microbit%2Fissues%2F3600%23issuecomment-722517452&data=04%7C01%7Cjhalleux%40microsoft.com%7C26fafaf594bb41a8edf808d881aed2ad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401935144523337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=83TVTbbAQ7yAI6O69T3lbzddzp2bboO08KsEmrXB7%2BY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKMBRV2W47L2O5RVRVLSOLM6RANCNFSM4TLT5DFQ&data=04%7C01%7Cjhalleux%40microsoft.com%7C26fafaf594bb41a8edf808d881aed2ad%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637401935144523337%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=abC2XAs7wtMpjwxtD0B7iDkudsq7d%2FPiwAVLKOISYtU%3D&reserved=0.

jaustin commented 4 years ago

@abchatra, @mmoskal, @carlosperate all felt that translating to their native language built-in was easier. That's not a huge sample size but here we've asked people and built-in is preferred anyway over on-board.