microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
708 stars 588 forks source link

Replace bread crumbs in extensions with the tab to be consistent #4592

Closed abchatra closed 1 year ago

abchatra commented 2 years ago

UI design: Instead of breadcrumbs it is better to show the extensions as new tab update

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Extensions'
  2. Click on 'Robotics' or Search for an extension

Screenshots image

Instead: image

abchatra commented 2 years ago

@unthinkmedia

unthinkmedia commented 2 years ago

What problem would this address? If we start to incorporate filtering (possibly in Arcade), it may start to get a bit busy. That being said, if you have a problem in mind that I am not aware of, let me know.

On Tue, Apr 26, 2022 at 5:53 PM Abhijith Chatra @.***> wrote:

@unthinkmedia https://github.com/unthinkmedia

— Reply to this email directly, view it on GitHub https://github.com/microsoft/pxt-microbit/issues/4592#issuecomment-1110286512, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LTVTRSRAXLLNUBCJZPQTVHBQU3ANCNFSM5UNGCTZQ . You are receiving this because you were mentioned.Message ID: @.***>

abchatra commented 2 years ago

Issue we discussed in the testing is the transition from tabbed UI to breadcrumb and going back is jarring. To go back to original view, one has to click on the breadcrumb. You can try in /beta

How does breadcrumb help with filtering?

unthinkmedia commented 2 years ago

This feels redundant to me and a bit confusing since that one tab functions quite differently than the others. It is actually almost functioning as a header. The other thing that I notice is that once you select a pill, then given it is above the tabs I would expect the tab to only include things inside of the selected section so for example. Show me only recommendations for LEDs.

[image: Apr-28-2022 10-59-13.gif]

Message ID: @.***>

Jaqster commented 2 years ago

Is "Installed" and "In Development" also filters? In general, I think we should try to be consistent about how filters show up across our product. What's the design pattern in other Microsoft products?

unthinkmedia commented 2 years ago

I wouldn't consider "In Development" a filter. That is more like My Assets and Gallery pattern. Something that I created and not publisher provided. I see installed being a state. The original design had installed as the first lane in the recommended view. I would be fine removing that and reverting back to that approach. That would remove all the tabs, because we could find another place for in development since that is an advanced setting. It doesn't need to be so pronounced. I will whip something up tonight for feedback

On Thu, Apr 28, 2022, 11:27 AM Jacqueline Russell @.***> wrote:

Is "Installed" and "In Development" also filters? In general, I think we should try to be consistent about how filters show up across our product. What's the design pattern in other Microsoft products?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/pxt-microbit/issues/4592#issuecomment-1112347695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LTVSNXWW5OS65RYDXJDDVHKU7RANCNFSM5UNGCTZQ . You are receiving this because you were mentioned.Message ID: @.***>

pelikhan commented 2 years ago

If you hide it when empty, you basically solve the problem for all/most beginner/intermediate users. Advanced users who build libraries won't mind.

What does it mean by the way, which scripts are supposed to end up there?

unthinkmedia commented 2 years ago

We:be removed the need for tabs since it is only required when a person has local github repo.

On Fri, May 6, 2022, 2:26 PM Abhijith Chatra @.***> wrote:

Assigned #4592 https://github.com/microsoft/pxt-microbit/issues/4592 to @unthinkmedia https://github.com/unthinkmedia.

— Reply to this email directly, view it on GitHub https://github.com/microsoft/pxt-microbit/issues/4592#event-6565427817, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN2LTVT3WD3O7XHOWDYRV2DVIVP6HANCNFSM5UNGCTZQ . You are receiving this because you were assigned.Message ID: @.***>

aznhassan commented 2 years ago

We no longer show the "In Development" (now "Local") tab if there are no such projects: image