search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
708 stars 588 forks source link

Music rest block units are potentially misleading #4658

Closed microbit-robert closed 1 year ago

microbit-robert commented 2 years ago

We have received feedback that the (ms) units on the music rest block are potentially misleading when the default selection is beat.

image

While music.beat() returns a number in ms, this is likely not clear for a lot of users and can lead to confusion.

Should the units be changed to (beats) be default?

The units as (ms) make sense when the block appears as:

image

Loosely connected to this issue, it looks as though there should be a space between rest and the unit. beat does not appear as a plural when selecting a value greater than one:

image

abchatra commented 1 year ago

Duplicate of https://github.com/microsoft/pxt-microbit/issues/4843 and will be fixed as part of that bug.