microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
704 stars 581 forks source link

Translations missing and cant be fixed in crowdin #4904

Open Amerlander opened 1 year ago

Amerlander commented 1 year ago

Describe the bug There are some translations, that are missing in german, spanish and some more languages.

image

They seem to be translated in Crowdin, at least the remainder block - I could not really tell what string has to be translated for the serial block. https://crowdin.com/translate/makecode/32/en-de?filter=basic&value=0#q=remainder

The remainder block in https://arcade.makecode.com/#editor is translated.

To Reproduce Steps to reproduce the behavior:

  1. Open makecode.microbit.org/ or makecode.calliope.cc/
  2. Change language to German or spanish
  3. Check the translations in the Math and Serial blocks.
MKleinSB commented 1 year ago

fixed serial write buffer in Crowdin.

MKleinSB commented 1 year ago

missing remainder string in crowdin @ganicke ?

jwunderl commented 1 year ago

These few missing translations appear to stem from blocks that have been changed in the code but not released yet. in particular this one is annoying with the remainder block, as that one is defined in pxt -- where the translations are shared between editors to reduce load / forgotten translations -- and is a bit of a 'special case' -- typically we avoid these issues by adding new blocks and deprecating the old ones.

If you check in /beta the translations are all fixed there, so they will be fixed when we do the next big release. For future cases, we should either 1. leave the old lf in the corner temporarily when we change strings, and get rid of it once that change has propagated to all editors, or 2. actively hotfix these sorts of minor string changes into the editor, so we don't have translations 'go missing' for months.

(I'm gonna remove the milestone from this one since it's complete in beta, but leave it open for the moment as we probably need to make a policy sorta decision on handling this issue better going forward @abchatra )

image