microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
721 stars 593 forks source link

Play recording on the sim should have similar reactions to play melody #5007

Closed kiki-lee closed 1 year ago

kiki-lee commented 1 year ago

When play recording is in the workspace, it should either trigger the v2 sim or add the connection points for the speaker like the play melody block does.

Screenshot by Dropbox Capture

abchatra commented 1 year ago

audio is v2 only feature and we should do exactly play sound block does which is also v2 feature.

This won't work on v1.

image

jwunderl commented 1 year ago

@srietkerk here's how you set the parts so we can detect that a function requires v2 just so you know //% parts="microphone" e.g. https://github.com/microsoft/pxt-microbit/blob/master/libs/microphone/microphone.cpp#L56

srietkerk commented 1 year ago

Closed via https://github.com/microsoft/pxt-microbit/pull/5057