search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
710 stars 589 forks source link

recording extension: No way to stop recording (without playback) #5125

Closed microbit-carlos closed 1 year ago

microbit-carlos commented 1 year ago

Currently, the only way to stop audio recording is with the playback block:

image

makecode.microbit.org version: 5.1.26 Microsoft MakeCode version: 8.6.33 microbit runtime version: v2.2.0-rc6 codal-microbit-v2 runtime version: v0.2.50

I think it might have been mentioned in the past that the [stop all sounds] block might be used for this, but trying it in this programme doesn't stop recording either:

microbit-record (3).hex.zip

image

Only pressing A+B to playback the recording stops it. We should probably have an explicit block for that, as users might just want to record a couple of seconds without playing them immediately after.

abchatra commented 1 year ago

@srietkerk stop all sounds doesn't work on this block?

srietkerk commented 1 year ago

It should with the changes that I pushed in recently, I need to bump beta.

microbit-carlos commented 1 year ago

The [stop all sounds] block doesn't fit very well for this purpose, no?

I don't see how the average user might guess that to stop recording they need to get a block from the "Music" toolboox that is called "stop all sounds". Specially since recording is an input, and sound is an output.

abchatra commented 1 year ago

@microbit-carlos by default the record audio block is going to be blocking and it automatically stops at 3 seconds by default settings or when playback is played . So adding stop recording didn't seem important at this point of time. We will add blocks if there are cases. I am closing for now as by design.

abchatra commented 1 year ago

Blocking part of the record audio is not checked in yet.