search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
726 stars 638 forks source link

Sim missing at exactly 991px width #5328

Closed jwunderl closed 1 year ago

jwunderl commented 1 year ago

Describe the bug

at exactly 991px width simulator disappears: image

991px is the breakpoint we switch between computer & tablet sizing (e.g. https://github.com/microsoft/pxt/blob/master/react-common/styles/react-common-breakpoints.less#L9), almost certainly we have some styling with a media query based off > largestTabletScreen and some based off < @largestTabletScreen or something to the effect

To Reproduce Steps to reproduce the behavior:

  1. Go to dev tools
  2. toggle device toolbar, dimensions responsive, set width to 991px
  3. open https://makecode.microbit.org/#editor
  4. See error

Expected behavior

We shouldn't lose sim

emoltz commented 1 year ago

See above but I was able to pinpoint the issue and the sim shows up at 991px wide now. https://github.com/microsoft/pxt/pull/9621

abchatra commented 1 year ago

Fixed