microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
721 stars 594 forks source link

[Programmatic Access - Make code - Share project]: 'Project link' read-only form field does not have a label. #5472

Closed vroopea closed 6 months ago

vroopea commented 9 months ago

User Experience:

Visually impaired people who depend on screen readers for navigation will get impacted as they won't be able to know the purpose of the read-only field and cannot copy the value for the project link.

Note:

User credentials should NOT be included in the bug.

Repro Steps:

  1. Launch application URL : https://makecode.microbit.org/.
  2. Home page will open.
  3. Navigate "New Project" option and select it.
  4. Editor screen will open.
  5. Navigate to "Share" option appearing in header section and select it.
  6. Navigate through all the controls of "Share Project" dialog and invoke share project.
  7. Turn on the AI (Accessibility Insights) and observe whether project link read-only field has label or not.

Actual Result:

Issue: 'Project link' read-only form field does not have a label.

Observation: When screen reader focus lands on the 'Project link' read-only field, the screen reader announces as "https://makecode.microbit.org/_1fE2E93pgaU6 read-only".

Expected Result:

Example: Aria-label="Project link" should be defined for the read-only field.

Note: The same issue is observed throughout the application for the similar controls.

Issue:

Ensures every form element has a label (label - https://accessibilityinsights.io/info-examples/web/label)

Target application:

Microsoft MakeCode for micro:bit - https://makecode.microbit.org/#editor

Element path:

.common-input

Snippet:

<input class="common-input" role="textbox" tabindex="0" type="text" readonly="" autocomplete="off" autocorrect="off" autocapitalize="off" value="https://makecode.microbit.org/_1fE2E93pgaU6">

How to fix:

Fix any of the following:

This accessibility issue was found using Accessibility Insights for Web 2.41.0 (axe-core 4.7.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

MAS Reference:

MAS 4.1.2 – Name, Role, Value

ARIA Authoring Ref Link/Fluent Patterns Guidance /HITS Guidance:

label.

UIA/DOM details available:

Yes (Refer the attachment)

Reference Links:

Test Environment:

vroopea commented 9 months ago

Accessibility;#A11yMAS;#A11ySev2;#A11yAuto;#k4W;#MAS4.1.2;#HCL;#Benchmark;#Win11-Chrome;#E2E-HCL-MakeCode-Feb2024

vroopea commented 7 months ago

As checked the issue on URL: https://makecode.microbit.org/. The issue is still repro and severity is fine. #Regressed:04-08-24;InternalReviewed-Apr2024