microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
721 stars 594 forks source link

[Programmatic Access - Make code - Editor page]: Required aria parent role is not defined for the 'Select code editor language' menu item. #5501

Closed vroopea closed 3 months ago

vroopea commented 8 months ago

User Experience:

People who use assistive technologies might find it difficult or impossible to use a child control if its managing control lacks the required parent role.

Note: User credentials should NOT be included in the bug.

Repro Steps:

  1. Launch application URL : https://makecode.microbit.org/.
  2. Home page will open. Turn on the screen reader (JAWS).
  3. Navigate "New Project" option and select it.
  4. Editor screen will open.
  5. Navigate to the 'Select code editor language' menu item and verify whether parent role is defined or not with the help of AI (Accessibility Insights)

Actual Result:

Issue: Required ARIA parents role not present: menu, menubar, group for the 'Select code editor language' menu item.

Observation: When focus lands on the 'Select code editor language' menu item, the screen reader announces as 'Dropdown menu - 'Select code editor language'.

Expected Result:

Issue:

Ensures elements with an ARIA role that require parent roles are contained by them (aria-required-parent - https://accessibilityinsights.io/info-examples/web/aria-required-parent)

Target application:

Microsoft MakeCode for micro:bit - https://makecode.microbit.org/#editor

Element path:

editordropdown

Snippet:

<div role="menuitem" title="Select code editor language" aria-haspopup="false" id="editordropdown" class="ui dropdown icon item button attached right " tabindex="0"> `

How to fix:

Fix the following:

MAS Reference: MAS 1.3.1 – Info and Relationships

ARIA Authoring Ref Link/Fluent Patterns Guidance /HITS Guidance:

aria-required-parent

UIA/DOM details available:

Yes (Refer the attachment)

Reference Links:

Test Environment:

MAS1 3 1_Required aria parent role is not defined for the 'Select code editor language' menu item DOM_MAS1 3 1_Required aria parent role is not defined for the 'Select code editor language' menu item
vroopea commented 8 months ago

Accessibility;#A11yMAS;#A11ySev3;#A11yAuto;#k4W;#MAS1.3.1;#HCL;#Benchmark;#Win11-Chrome;#E2E-HCL-MakeCode-Feb2024