search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
713 stars 588 forks source link

Make pins.map block inline #5713

Closed sae220 closed 1 month ago

sae220 commented 3 months ago

I accidentially closed previous pull request (https://github.com/microsoft/pxt-microbit/pull/5697).

@abchatra Could you review this simple pull request? Or could you let me know why it should not be inline?

abchatra commented 3 months ago

@sae220 can you attach the screenshot of change in blocks?

sae220 commented 3 months ago

inlinePinMap_2 inlinePinMap_1 I don't know why pins_map is needed anyway.

abchatra commented 1 month ago

@sae220 we won't be taking this change as we don't want to change the look of this block due to legacy reasons. (Too many teachers have screenshots).