search

microsoft / pxt-microbit

A Blocks / JavaScript code editor for the micro:bit built on Microsoft MakeCode
https://makecode.microbit.org
Other
725 stars 597 forks source link

Right-clicking on workspace unselects block #5861

Open Jaqster opened 2 months ago

Jaqster commented 2 months ago

On Beta, Edge.

I used to be able to highlight a block on the workspace and then take a snapshot - this was useful to be able to call attention to a specific block in a screenshot.

But now, when I right-click to open the context menu on the workspace, the highlighted block is un-selected.

Production - image

Beta - image

riknoll commented 2 months ago

hmmm.. this isn't easy to fix since it would require changes to blockly's internals.

as a side note the old behavior was always annoying to me personally since i would forget that i have a block selected and be forced to retake the screenshot. your use case makes sense though... would it be acceptable to add a new entry to the block's context menu that lets you highlight a block?

Jaqster commented 2 months ago

Interesting thought. Mulling over this more... I do like this idea. Especially if you could highlight multiple blocks in a program and have that persist. But then that might conflict with the block selection behavior? When you select a highlighted block nothing happens. And if you have multiple blocks highlighted in a program, how can you tell which one is selected? I think there might be too many gotchas here... We can close this with a workaround that you'll just have to do a manual screenshot if you want to show selected blocks (like we have to do to show open field editors already).

Jaqster commented 2 months ago

BTW - just looking at the workspace context menu again... are we missing Search?

riknoll commented 2 months ago

you're right, it's missing. i'll add it back,

i had no idea we put it in the right click menu in live. is that normal behavior for other sites?

jwunderl commented 2 months ago

I believe it was the mobile / touch entry point, since 'find in page' in browser menu just goes to text find (unless they give options to override that?)