support packages - Githubissues

pelikhan commented 6 years ago

7 packages with errors

[x] laboratoryforplayfulcomputation/pxt-blockytalkyble
[ ] sunfounder/pxt-sloth https://github.com/sunfounder/pxt-sloth/pull/4
[x] microsoft/pxt-filesystem not in search
[x] emwta/pxt-iBit https://github.com/emwta/pxt-iBit/pull/5
[x] sparkfun/pxt-weather-bit https://github.com/sparkfun/pxt-weather-bit/pull/15
[x] microsoft/pxt-bluetooth-midi
[x] pimoroni/pxt-scrollbit https://github.com/pimoroni/pxt-scrollbit/pull/1
[ ] Seeed-Studio/pxt-grove https://github.com/Seeed-Studio/pxt-grove/issues/5 (not approved)

found 42 packages

kittenbot/pxt-robotbit microsoft/pxt-neopixel srs/pxt-bitbot kitronikltd/pxt-kitronik-servo-lite microsoft/pxt-sonar microsoft/pxt-bluetooth-temperature-sensor microsoft/pxt-max6675 seeed-studio/pxt-grove microsoft/pxt-midi microsoft/pxt-bluetooth-midi microsoft/pxt-filesystem tinkertanker/pxt-oled-ssd1306 minodekit/pxt-minode chevyng/pxt-ucl-junkrobot microsoft/pxt-bluetooth-max6675 laboratoryforplayfulcomputation/pxt-blockytalkyble tinkertanker/pxt-iot-environment-kit tinkertanker/pxt-realtimeclock-ds1307 microsoft/pxt-microturtle kitronikltd/pxt-kitronik-motor-driver sunfounder/pxt-sloth pizayanz/pxt-linebeacon CoderDojoOlney/pxt-olney PaulDFoster/pxt-microbit-GY521 chevyng/pxt-ucl-junkrobot srs/pxt-bitbot sparkfun/pxt-gamer-bit sparkfun/pxt-moto-bit sparkfun/pxt-weather-bit minodekit/pxt-minode LaboratoryForPlayfulComputation/pxt-BlockyTalkyBLE mbitfun/pxt-katakana jdarling/pxt-pca9685 MUSELAB/pxt-wifi-shield kittenbot/pxt-robotbit pizayanz/pxt-linebeacon sunfounder/pxt-sloth 4tronix/BitBot pimoroni/pxt-scrollbit emwta/pxt-iBit vengit/pxt-sbrick Annikken/pxt-Andee

mmoskal commented 6 years ago

The following contain C++:

microsoft/pxt-filesystem
sparkfun/pxt-weather-bit
microsoft/pxt-bluetooth-midi
pimoroni/pxt-scrollbit

In scrollbit the C++ is just fine.

pelikhan commented 6 years ago

@microbit-mark FYI

microbit-mark commented 6 years ago

Most packages have now been updated from this list. Do you have a cutoff date for this @pelikhan

guillaumejenkins commented 6 years ago

I just tried pxt-sloth (the last one in the above list) and I'm getting the following compile errors when clicking Play on the simulator:

[
    {
        "code": 2450,
        "start": 83,
        "length": 6,
        "line": 4,
        "column": 20,
        "messageText": "Enum 'PWMChn' used before its declaration.",
        "category": 1,
        "fileName": "pxt_modules/sloth/sloth.ts"
    },
    {
        "code": 2450,
        "start": 121,
        "length": 6,
        "line": 5,
        "column": 21,
        "messageText": "Enum 'PWMChn' used before its declaration.",
        "category": 1,
        "fileName": "pxt_modules/sloth/sloth.ts"
    },
    {
        "code": 2450,
        "start": 159,
        "length": 6,
        "line": 6,
        "column": 20,
        "messageText": "Enum 'PWMChn' used before its declaration.",
        "category": 1,
        "fileName": "pxt_modules/sloth/sloth.ts"
    },
    {
        "code": 2450,
        "start": 195,
        "length": 6,
        "line": 7,
        "column": 19,
        "messageText": "Enum 'PWMChn' used before its declaration.",
        "category": 1,
        "fileName": "pxt_modules/sloth/sloth.ts"
    }
]

jaustin commented 6 years ago

How about #1015 - did the testing above cover the UI side of things or just that they imported and compiled?

guillaumejenkins commented 6 years ago

~~Before closing this we need to figure out what to do with existing projects that rely on older, incompatible versions of a package (for example pxt-sloth and enum declaration order)~~

~~We could detect compilation problems on project load, and then popup a message telling the user we will bring them back to v0~~

Edit: Let's use https://github.com/Microsoft/pxt-microbit/issues/1102 to track auto-upgrade failing, and keep this issue specifically about making the packages work in v1. This issue will be complete as soon as the PR in pxt-sloth goes in.

guillaumejenkins commented 6 years ago

All that's left for this issue is for @sunfounder to bump the pxt-sloth package

pelikhan commented 6 years ago

@microbit-mark Seeed-Studio/pxt-grove also impacted but I don't think it was ever approved.

FranklinWhale commented 6 years ago

I think Seeed-Studio/pxt-grove is an approved package because it is available in the search results and the Package Gallery

pelikhan commented 6 years ago

Looks like the compilation based detection might have missed a bunch of cases. I've resorted to regexes and this is the current tool output.

UPDATE: the detector has a lot of false positives, investigating

23 packages with errors

[ ] laboratoryforplayfulcomputation/pxt-blockytalkyble: invalid tag #alpha1.1
[x] CoderDojoOlney/pxt-olney div found in olney.ts
[x] k8robotics/pxt-k8 div found in motion.ts, sonar.ts
[x] PaulDFoster/pxt-microbit-GY521 div found in CurrentBestmain.ts
[x] pimoroni/pxt-envirobit div found in envirobit.ts
[ ] emwta/pxt-iBit Error: Exit code: 20 from cd temp\ghpkgs\emwta\pxt-iBit; node C:\gh\pxt-microbit\node_modules\pxt-core\pxt-cli\cli.js build --ignoreTests --warndiv
[x] dexterind/pxt-giggle div found in giggle.ts
[ ] sunfounder/pxt-sloth Error: Exit code: 1 from cd temp\ghpkgs\sunfounder\pxt-sloth; node C:\gh\pxt-microbit\node_modules\pxt-core\pxt-cli\cli.js build --ignoreTests --warndiv
[x] vengit/pxt-sbrick div found in test.ts
[x] sparkfun/pxt-weather-bit div found in weatherbit.ts
[x] mbitfun/pxt-katakana div found in main.ts
[x] Annikken/pxt-Andee div found in main.ts
[x] dexterind/pxt-gigglebot div found in gigglebot.ts
[x] 4tronix/BitBot div found in main.ts
[x] MUSELAB/pxt-wifi-shield div found in wifi.ts
[x] kittenbot/pxt-robotbit div found in main.ts
[x] pimoroni/pxt-scrollbit div found in scrollbit.ts
[x] chevyng/pxt-ucl-junkrobot div found in main.ts
[x] jdarling/pxt-pca9685 div found in driver.ts
[x] srs/pxt-bitbot div found in main.ts
[x] kitronikltd/pxt-kitronik-servo-lite div found in servolite.ts
[x] seeed-studio/pxt-grove div found in main.ts
[x] tinkertanker/pxt-iot-environment-kit div found in environment.ts

abchatra commented 6 years ago

@pelikhan I have filed on all the repos except 3 as above.

jdarling commented 5 years ago

Late to the party (sorry was away from the connected world for a bit) but want to put in my two cents. Two things would have made this easier:

1) A way to test changes from branches without effecting current live 1a) Automated test framework that works with PR's 2) Someone would have taken the few seconds to write the Monkey Path and stuff it into the v0

Math.idiv = Math.idiv || (a, b)=>a/b;

Anyways I've patched up my component and merged the PR. Is there anything else that is required in order to ensure the package is still available and working?

abchatra commented 5 years ago

@jdarling we do have Math.idiv in v0

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

microsoft / pxt-microbit

support packages #849