microsoft / pxt-mkc

Command line tool for MakeCode editors
https://microsoft.github.io/pxt-mkc/
MIT License
11 stars 6 forks source link

fix: memory leak in makecode-browser #103

Closed jwunderl closed 1 year ago

jwunderl commented 1 year ago

Right now we're spinning up a new worker on any request that needs a language service. This only takes ~50ms to spin up, but we're also leaving the old one around, increasing memory usage by ~5-10mb per compile

fix https://github.com/microsoft/vscode-makecode/issues/78

(and to confirm, this shouldn't have affected makecode-node at all as that spins up a new node process whenever you call into it from cli, correct?)

riknoll commented 1 year ago

yeah, shouldn't affect node!