search

microsoft / pxt-robotis

Microsoft MakeCode for ROBOTIS
https://5d8c71b7-aa36-4a68-a9cb-288b989efb08.pxt.io/
MIT License
4 stars 7 forks source link

Added cm-300 board files & deleted unnecessary files. #3

Closed robotisApp closed 4 years ago

robotisApp commented 4 years ago
pelikhan commented 4 years ago

Do not use travis, it will not work for private repoes.

kigateG commented 4 years ago

Hi. How can I fix the 2 errors. hex file & compiler test failed. I think I saw the message in the following cases.

1. ["compileServiceVariant": "nrf52840"] in [pxt-robotis/libs/robotis-cm-300-01/pxt.json]. [pxt-robotis/libs/robotis-cm-300-01-blocks] has cpp files. => no error

2. ["compileServiceVariant": "cm300"] in [pxt-robotis/libs/robotis-cm-300-01/pxt.json]. [pxt-robotis/libs/robotis-cm-300-01-blocks] has cpp files. => error

3. ["compileServiceVariant": "cm300"] in [pxt-robotis/libs/robotis-cm-300-01/pxt.json]. [pxt-robotis/libs/robotis-cm-300-01-blocks] has NO cpp files. => no error

BUT, now.... Nothing special has been modified, but case2. shows No error.

pelikhan commented 4 years ago

There is still a ton of useless libs in there like "esp32". You need to clean up and remove all the unecessary libs first then add them back later. When do you plan to get this PR ready?

Note: i don't like to review massive PRs so use 1 PR per review.

kigateG commented 4 years ago

Hello. I found a similar issue. https://github.com/Microsoft/pxt-maker/issues/73

It works fine in local PC with command "pxt serve --localbuild". But Bad HTTP status code: 412 on Github.

What should I do?

pelikhan commented 4 years ago

This PR is too large to review. Please merge it and identify issues in separate smaller chunks. I don't have the time to review 800+ files PRs.

kigateG commented 4 years ago

This PR is too large to review. Please merge it and identify issues in separate smaller chunks. I don't have the time to review 800+ files PRs.

Thank you. First, I will delete the unnecessary code and leave a comment.