Modify Download Message...

[kigateG]

Hi.

Can I change download message UI like microbit?

->

I tried with below codes to change body ("Move the ...") but not work. https://github.com/microsoft/pxt-robotis/blob/4f62b68301184d21a0a410d9248ffbe863bfa052/editor/extension.ts#L59

And I tried with below. It works. Do I have to change pxt? https://github.com/microsoft/pxt/blob/5531f0a3fe88242be6d4ce899c25ca3c61323ca6/webapp/src/cmds.ts#L82

thanks.

[pelikhan]

You can provide your own UI for the download dialog via the editor extensions. See the microsoft/pxt-microbit project for an example of such use.

https://github.com/microsoft/pxt-microbit/blob/master/editor/extension.tsx#L968

[pelikhan]

And enable this field in pxtarget.json

https://github.com/microsoft/pxt-microbit/blob/master/pxtarget.json#L296

[pelikhan]

Peli to add skeleton code.

[kigateG]

Maker and Robotis targets already use the filed and function like below. Are there any settings I missed?

https://github.com/microsoft/pxt-robotis/blob/4f62b68301184d21a0a410d9248ffbe863bfa052/pxtarget.json#L246

https://github.com/microsoft/pxt-robotis/blob/4f62b68301184d21a0a410d9248ffbe863bfa052/editor/extension.ts#L7

[pelikhan]

You are right, we had a bug in pxt. You will need to integrate this commit

https://github.com/microsoft/pxt-maker/commit/d083bb864b8c05a89b9cf436213fdd26e397e9a9

and bump pxt to the latest to pick up the fixes.

[pelikhan]

Ping me if you need help integrating these changes.

[kigateG]

Hi, I did...

delete extension.ts add extension.tsx modify tsconfig.json and package.json

then...

npm install

Log has no error. But it still show the message box only...

[pelikhan]

I’ll do the patch.

---

From: kigateG notifications@github.com Sent: Monday, April 6, 2020 7:08:12 PM To: microsoft/pxt-robotis pxt-robotis@noreply.github.com Cc: Peli de Halleux jhalleux@microsoft.com; Comment comment@noreply.github.com Subject: Re: [microsoft/pxt-robotis] Modify Download Message... (#34)

Hi, I did...

delete extension.ts add extension.tsx modify tsconfig.json and package.json

then...

npm install

Log has no error. But it still show the message box only... [image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F61178787%2F78622305-c3f63280-78bf-11ea-9fa3-6402fe836a95.png&data=02%7C01%7Cjhalleux%40microsoft.com%7Cb103e9e7ef884bf596a008d7da9886f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218220945027430&sdata=tAChhVEKq7Fyer7Ing4x95A0awny44283LJuWeq7%2BJM%3D&reserved=0

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fpxt-robotis%2Fissues%2F34%23issuecomment-610132103&data=02%7C01%7Cjhalleux%40microsoft.com%7Cb103e9e7ef884bf596a008d7da9886f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218220945027430&sdata=ihxxQ%2BFkNt40cRrJeoF%2FrsJYJJiQkC7NCGC3YQ%2BkMxA%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA73QKPISDQL36EXBWJKVH3RLKDIZANCNFSM4LTCBHSA&data=02%7C01%7Cjhalleux%40microsoft.com%7Cb103e9e7ef884bf596a008d7da9886f5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637218220945037428&sdata=g%2F2iyZ0EaNQBaNPrce0BcPo2%2FlJhIsL3Tzn2dDnQD8s%3D&reserved=0.

[pelikhan]

Fixed.

[kigateG]

Thank you pelikhan.