microsoft / pxt

Microsoft MakeCode (PXT - Programming eXperience Toolkit)
https://makecode.com
MIT License
2.1k stars 588 forks source link

Some app.tsx cleanup #10215

Closed riknoll closed 1 month ago

riknoll commented 1 month ago

as i was tracing our tutorial loading code, i went ahead and fixed a few tiny bugs and converted some functions to async/await. i know the async/await changes make it a little difficult to tell what changed, so here's a summary of the few actual behavior changes:

  1. removed a redundant call to compiler.newProjectAsync() in internalLoadHeaderAsync
  2. removed a redundant call to pxt.github.cacheProjectDependenciesAsync() in createProjectAsync()
  3. made the github repo db keys in idbworkspace.ts case insensitive so that we don't miss the cache when a markdown author is inconsistent with their capitalization (this was happening in the HOC minecraft tutorials)