microsoft / pxt

Microsoft MakeCode (PXT - Programming eXperience Toolkit)
https://makecode.com
MIT License
2.1k stars 588 forks source link

don't fire type checks on blockly theme changes #10218

Closed riknoll closed 1 month ago

riknoll commented 1 month ago

fixes https://github.com/microsoft/pxt-minecraft/issues/2557

minecraft is our only editor that actually customizes the blockly theme. setting the theme was causing blockly to fire an event which in turn triggered a type check on the home screen. that type check fails because there is no project open when you're on the home screen

abchatra commented 1 month ago

Thanks!