microsoft / pxt

Microsoft MakeCode (PXT - Programming eXperience Toolkit)
https://makecode.com
MIT License
2.1k stars 588 forks source link

Zip downloading: added modal for successfully downloading zips in game #10255

Closed srietkerk closed 3 weeks ago

srietkerk commented 3 weeks ago

When downloading zips in-game in Minecraft, there is no indicator that tells you that a download was successful like you get in-browser with browser built-ins. This PR adds a modal that pops up only if you are in game after downloading a zip. I also added a check for showing the download zip button because you shouldn't be able to download a zip of the projects if you can't interact with the filesystem, regardless of the target.

edit: Fixes https://github.com/microsoft/pxt-minecraft/issues/2437

image

Upload target: https://minecraft.makecode.com/app/b439897404713a96f9e8313e79029cbb195288ed-91a4b94271?inGame=1

srietkerk commented 3 weeks ago

Discussed that because the timeout and the lack of ability to know what happens when the user interacts with the file system, the modal wasn't useful enough to the user.