microsoft / pxt

Microsoft MakeCode (PXT - Programming eXperience Toolkit)
https://makecode.com
MIT License
2.1k stars 588 forks source link

use anchor element for social links when in game #10277

Open riknoll opened 1 week ago

riknoll commented 1 week ago

fixes https://github.com/microsoft/pxt-minecraft/issues/2668

the in-game webview on macos doesn't support any of the window open APIs that the browser provides.<a> elements work though, so this PR replaces the social buttons with <a> elements.

normally i would just replace these for all platforms since <a> elements are usually better for accessibility, but the only way to open a pop up window is with js and i think that's the expected behavior for social buttons. doesn't matter for the in-game experience given that those all open in the browser outside the game anyhow.

abchatra commented 1 week ago

@riknoll build failing

riknoll commented 1 week ago

@abchatra i'll fix it, but leave this one out of the release anyhow. i'd like more people to test it first so let's save it for the hotfix

abchatra commented 1 week ago

Sounds good.