microsoft / pxt

Microsoft MakeCode (PXT - Programming eXperience Toolkit)
https://makecode.com
MIT License
2.07k stars 578 forks source link

Missing images on some docs pages #8691

Open Jaqster opened 2 years ago

Jaqster commented 2 years ago

Noticed that some images were missing from these docs pages: https://arcade.makecode.com/identity/cloud-sync image

https://arcade.makecode.com/identity/sign-in image

ganicke commented 2 years ago

Hmm, this happens with the github pages too:

https://arcade.makecode.com/github/sign-up

The images in common_docs pages aren't being pulled from their ./common-docs/static location but from the current ./target/docs/static location?

ganicke commented 2 years ago

@shakao - any ideas why these images aren't found?

image

Works with local serve:

image

shakao commented 2 years ago

yeah weird, it looks like we're not looking for images under /common-doc, but it doesn't seem like any of that code has changed recently.... @aznhassan any idea if anything in our backend path expansion might have affected this?

Jaqster commented 2 years ago

Ummm.... these pages are down now. What's going on? image

image

abchatra commented 2 years ago

@Jaqster I can reach those pages. Internet issues?

jwunderl commented 2 years ago

I think you're missing the arcade. subdomain~

Jaqster commented 2 years ago

Hmmmm... no internet issues. Tried lots of other docs pages and different browsers. These are the right links (not on Arcade domain) - they are linked from Eric's blog post - https://makecode.com/blog/arcade/intro-cloud-sync

ganicke commented 2 years ago

Those links in the blog are incorrect as these pages are inherited by targets from pxt ./common-docs.

Jaqster commented 2 years ago

Okay, can we change those links in the blog post then?

ganicke commented 2 years ago

But, of course... #8715