Unimported pytest fixtures are recognized by hover

[debonte]

• Language Server version: 2023.9.31
• OS and version: Windows 11
• Python version: 3.11.5

Code Snippet

test_fixtures.py

from pytest import fixture

@fixture
def fixture_one():
    return 1

@fixture
def fixture_two():
    return 2

test_repro.py

from test_fixtures import fixture_one

def test_foo(fixture_two):
    pass

Repro Steps

0. Add pytest to your venv
1. Create files shown above
2. Hover over fixture_two usage in test_repro.py

Expected behavior

Type of fixture_two is unknown since it is not imported. If you comment out the import of fixture_one you get the expected behavior:

Actual behavior

Hover shows def fixture_two() -> Literal[2]

[rchiodo]

I can repro this but this may be because fixture_two is allowed from pytest's point of view. Double checking.

[rchiodo]

No the test fails with the expected error. You have to actually import the fixture for the test to pass.