search

microsoft / pylance-release

Documentation and issues for Pylance
Creative Commons Attribution 4.0 International
1.69k stars 767 forks source link

`latest-release` is not updated since version `1.1.360` #6122

Closed tylerlaprade closed 2 weeks ago

tylerlaprade commented 1 month ago

https://github.com/microsoft/pylance-release/blob/main/releases/latest-release.json

This should be 1.1.371.

See also: https://github.com/jakebailey/pyright-action/issues/133

debonte commented 1 month ago

Thanks for pointing this out @tylerlaprade! We've recently changed how our release automation works, so I assume this is a bug in those changes.

In the meantime, I just manually updated the file.

debonte commented 1 month ago

Looks like we're always updating latest-prerelease.json, even if the release is a stable release. Here are links to recent release logs:

Note that in both the stable releases (2024.6.1, 2024.7.1) and the prerelease (2024.6.104), we're modifying releases/latest-prerelease.json:

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
    new file:   releases/2024.7.1.json
    modified:   releases/latest-prerelease.json
debonte commented 1 month ago

Ah, the problem is that AzDO is passing False (capitalized) for the isPrerelease option on savePyrightVersionMetadata.js and apparently yargs isn't handling that the way we expected:

debonte commented 1 month ago

I believe I've fixed this, but I'll leave this open until our next stable release ships and verify at that point.

debonte commented 2 weeks ago

Closing. Confirmed that the fix worked as expected when 2024.8.1 shipped -- https://github.com/microsoft/pylance-release/commit/59c07ab6322b89b8d35b991526597286e971e0c8

Thanks for reporting this issue @tylerlaprade!