search

microsoft / pyright

Static Type Checker for Python
Other
13.04k stars 1.39k forks source link

Pyright v1.1.370 has incorrect min vscode engine version as 1.86 #8344

Closed aadisriram closed 1 month ago

aadisriram commented 1 month ago

Describe the bug Pyright v1.370+ has the engine version in package.json set to 1.86, however when starting pyright on 1.86 the following error is thrown in the console:

The language client requires VS Code version ^1.89.0 but received version 1.86.<>

Code or Screenshots This is happening because the languageserver node package pyright depends on has a min engine version of 1.89 https://github.com/microsoft/vscode-languageserver-node/blob/release/client/10.0.0-next.6/client/package.json

image
erictraut commented 1 month ago

Thanks for the bug report. This will be fixed in the next release.

@debonte, @rchiodo, looks like this was broken by a recent change that came in through a pylance update.

erictraut commented 1 month ago

This is addressed in pyright 1.1.371.