Reapply the compiler flags change but separate out the 'language server' specific settings

microsoft / pyright

Static Type Checker for Python

Other

13.12k stars 1.4k forks source link

Reapply the compiler flags change but separate out the 'language server' specific settings #8726

Closed rchiodo closed 1 month ago

rchiodo commented 1 month ago

This is a reapplication of https://github.com/microsoft/pyright/pull/8704 but with also taking into account flags that have to always be set even when a pyrightconfig.json is present because these flags are not settable by a pyrightconfig.json.

I tested vscode-pyright with this change and it takes the diagnostic mode into account correctly now and watches for file changes. This wasn't working with the original submission.

Addresses https://github.com/microsoft/pyright/issues/8719

github-actions[bot] commented 1 month ago

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅