search

microsoft / pyright

Static Type Checker for Python
Other
13.12k stars 1.4k forks source link

Fixed a bug that results in a false negative when overloads overlap d… #8844

Closed erictraut closed 2 weeks ago

erictraut commented 2 weeks ago

…ue to default values.

github-actions[bot] commented 2 weeks ago

Diff from mypy_primer, showing the effect of this PR on open source code:

core (https://github.com/home-assistant/core)
+   /tmp/mypy_primer/projects/core/homeassistant/helpers/template.py:3069:9 - error: Overload 1 for "compile" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- 23899 errors, 338 warnings, 0 informations 
+ 23900 errors, 338 warnings, 0 informations 

pandas (https://github.com/pandas-dev/pandas)
+   /tmp/mypy_primer/projects/pandas/pandas/io/sql.py:236:5 - error: Overload 1 for "read_sql_table" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
+   /tmp/mypy_primer/projects/pandas/pandas/io/sql.py:367:5 - error: Overload 1 for "read_sql_query" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
+   /tmp/mypy_primer/projects/pandas/pandas/io/sql.py:503:5 - error: Overload 1 for "read_sql" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- 572 errors, 2 warnings, 0 informations 
+ 575 errors, 2 warnings, 0 informations 

werkzeug (https://github.com/pallets/werkzeug)
+   /tmp/mypy_primer/projects/werkzeug/src/werkzeug/wrappers/request.py:373:9 - error: Overload 1 for "get_data" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- 140 errors, 10 warnings, 0 informations 
+ 141 errors, 10 warnings, 0 informations 

bokeh (https://github.com/bokeh/bokeh)
+   /tmp/mypy_primer/projects/bokeh/src/bokeh/embed/standalone.py:136:5 - error: Overload 1 for "components" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
+   /tmp/mypy_primer/projects/bokeh/src/bokeh/embed/standalone.py:143:5 - error: Overload 3 for "components" overlaps overload 4 and returns an incompatible type (reportOverlappingOverload)
+   /tmp/mypy_primer/projects/bokeh/src/bokeh/embed/standalone.py:150:5 - error: Overload 5 for "components" overlaps overload 6 and returns an incompatible type (reportOverlappingOverload)
- 3530 errors, 305 warnings, 0 informations 
+ 3533 errors, 305 warnings, 0 informations 

pandas-stubs (https://github.com/pandas-dev/pandas-stubs)
+   /tmp/mypy_primer/projects/pandas-stubs/pandas-stubs/core/groupby/generic.pyi:210:9 - error: Overload 1 for "aggregate" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
-   /tmp/mypy_primer/projects/pandas-stubs/pandas-stubs/core/indexes/interval.pyi:369:5 - error: Overload 7 for "interval_range" overlaps overload 10 and returns an incompatible type (reportOverlappingOverload)

jax (https://github.com/google/jax)
+   /tmp/mypy_primer/projects/jax/jax/_src/api.py:2298:5 - error: Overload 1 for "make_jaxpr" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- 6306 errors, 26 warnings, 0 informations 
+ 6307 errors, 26 warnings, 0 informations 

prefect (https://github.com/PrefectHQ/prefect)
+   /tmp/mypy_primer/projects/prefect/src/prefect/client/orchestration.py:155:5 - error: Overload 1 for "get_client" overlaps overload 2 and returns an incompatible type (reportOverlappingOverload)
- 8983 errors, 252 warnings, 0 informations 
+ 8984 errors, 252 warnings, 0 informations