microsoft / python-language-server

Microsoft Language Server for Python
Apache License 2.0
912 stars 131 forks source link

Renaming unreliable - Go to Definition unreliable #1881

Open lumyx2 opened 4 years ago

lumyx2 commented 4 years ago

Issue Type: Bug

F12 does not always work or takes forever. I've tried the jedi flag, still no change. The problem seems to disappear if VS Code is restarted. After some hours it comes back. Some times it recovers after taking forever and others it just shows some message along the lines of Not Found.

The same happens with rename. The added effect is that sometimes it renames "some" of the matches. So then you need to debug the code to find out in what files and in what parts of a file the variables/functions have been renamed.

VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z) OS version: Windows_NT x64 10.0.18362

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-4702MQ CPU @ 2.20GHz (8 x 2195)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.72GB (5.81GB free)| |Process Argv|--folder-uri file:///f%3A/Eng_Cambridge/PhD/Project_WorkSpace_Python/ws_opm_wprior| |Screen Reader|no| |VM|0%|
Extensions (29) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|2.0.5 Bookmarks|ale|10.6.0 project-manager|ale|10.9.1 bracket-pair-colorizer-2|Coe|0.0.29 vscode-eslint|dba|2.0.15 githistory|don|0.4.13 vscode-gitignore-syntax|dun|0.1.2 gitlens|eam|10.2.0 vscode-npm-script|eg2|0.3.10 todo-tree|Gru|0.0.165 asciidecorator|hel|0.2.0 beautify|Hoo|1.5.0 theme-by-language|jsa|1.1.1 vscode-map-preview|jum|0.4.8 vscode-github|Kni|0.30.3 MagicPython|mag|1.1.0 anaconda-extension-pack|ms-|1.0.1 python|ms-|2020.1.58038 remote-wsl|ms-|0.41.7 vscode-json-editor|nic|0.2.3 indent-rainbow|ode|7.4.0 fix-json|oli|0.1.2 vscode-gitignore-generator|pio|1.0.1 material-icon-theme|PKi|3.9.2 vscode-yaml|red|0.6.1 highlight-words|rsb|0.1.4 indenticator|Sir|0.6.0 selectline-statusbar|tom|0.0.2 html-css-class-completion|Zig|1.19.0 (2 theme extensions excluded)
brettcannon commented 4 years ago

[ @lumyx2 I edited your ✉️ ⬆️ to come off as more 😃 and less 😠 ]

brettcannon commented 4 years ago

This functionality is provided by Rope when you use Jedi as you know and we don't control that, so we can't fix that. We are trying to improve refactoring in our language server.