search

microsoft / python-language-server

Microsoft Language Server for Python
Apache License 2.0
915 stars 133 forks source link

Cannot go to definition if the path contains Cyrillic characters #2099

Open moprules opened 4 years ago

moprules commented 4 years ago

Issue Type: Bug

If the project path contains Russian letters, you can't find the module using "ctrl+click_on_module_name", even if the modules are in the same folder.

1) path contains Russian letters - "Документы" /home/mop/Документы/projects/test_bug image

2) the same project without Russian letters in the path to the project /home/mop/test_bug image image image

In 1 case the module path is duplicated twice

Extension version: 2020.6.91350 VS Code version: Code 1.46.1 (cd9ea6488829f560dc949a8b2fb789f3cdc05f5d, 2020-06-17T21:13:08.304Z) OS version: Linux x64 5.3.0-62-generic

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i3 CPU U 380 @ 1.33GHz (4 x 1330)| |GPU Status|2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_renderer: disabled_off_ok
video_decode: unavailable_off
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled| |Load (avg)|2, 1, 1| |Memory (System)|3.65GB (0.43GB free)| |Process Argv|--no-sandbox --unity-launch| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|/usr/share/xsessions/plasma| |XDG_CURRENT_DESKTOP|KDE| |XDG_SESSION_DESKTOP|KDE| |XDG_SESSION_TYPE|x11|
kimadeline commented 4 years ago

Hi @ogurechik, thank you for reaching out!

I could reproduce your issue locally only when using the Microsoft Python Language Server, and not with Jedi nor Pylance, which is a faster and improved version of MPLS.

I'd suggest giving Pylance a try by downloading the Pylance extension from the Marketplace, and I'll transfer this issue to the MPLS repo in the meantime.

Thank you!

moprules commented 4 years ago

@kimadeline, thank you very much Pylance solved this problem and also solved the problem with pylint