Update automated tests, pass as-is

Avasam commented 1 year ago

Work towards #296

Counterpart to #302 but this only touches configurations and infra. No stub change here except for stubs/scipy-stubs/optimize/cython_optimize/__init__.pyi (which is purely a mypy workaround otherwise it wouldn't even run due to same-name modules). So you can decide which you want first. There will be slight conflicts but I'll resolve them.

Add mypy, isort and black tests to GitHub actions
Move pyright configs to be automatically picked up by Editor, CLI and CI
Move typeCheckingMode setting from IDE only to pyright configs
Move warn-partial setting from GitHub actions to pyright configs
Remove redundant default mypy settings
Turn on show_column_numbers in mypy
Bump minimum supported version to 3.8
Ignore existing errors (preferably as warnings) and mark them as TODO
Exclude/skip files where the error cannot be globally ignored, and mark them as TODO
Remove empty tests/__init__.py
Add stubs/scipy-stubs/optimize/cython_optimize/__init__.pyi to get mypy to run
Added all parent libraries needed to validate typing in tests/requirements.txt
Use pyright-python's PYRIGHT_PYTHON_PYLANCE_VERSION to ensure better sync with Pylance
Converge tests/run_tests.sh and tests/run_tests.cmd into a Python script, simplified the commands, and update to run all the tests
Added tests/run_formatters.py to run all code fixers and formatters

Avasam commented 3 months ago

Updated with latest review comments! Btw feel free to squash commit once this is accepted. I avoid rebases/force-pushes on GitHub to make it easier on the reviewer to see latest changes.

debonte commented 3 weeks ago

What is the status of this PR?

Avasam commented 3 weeks ago

What is the status of this PR?

Unless you have any other comment, it's good to be squash-merged on my side if it passes the CI. https://github.com/microsoft/python-type-stubs/pull/301#discussion_r1714086800 and https://github.com/microsoft/python-type-stubs/pull/301#discussion_r1811575673 are more follow-ups than something to be done here.

Avasam commented 3 weeks ago

The conflict is caused by: The user requested typing_extensions==4.2.0 mypy 1.11.2 depends on typing-extensions>=4.6.0 The user requested typing_extensions==4.2.0 mypy 1.11.1 depends on typing-extensions>=4.6.0 The user requested typing_extensions==4.2.0 mypy 1.11.0 depends on typing-extensions>=4.6.0

I unpinned typing_extensions to just follow what mypy uses

debonte commented 2 weeks ago

@Avasam, thanks for your work here!

microsoft / python-type-stubs

Update automated tests, pass as-is #301