search

microsoft / python-type-stubs

A set of type stubs for popular Python packages. These are works in progress from the Microsoft Python team and others, with the intent that they are contributed to typeshed or to the associated packages once sufficiently complete.
MIT License
252 stars 98 forks source link

Missing parameter for sklearn.ensemble.HistGradientBoostingRegressor #322

Open ara-incom opened 5 days ago

ara-incom commented 5 days ago

Since scikit-learn 1.4 HistGradientBoostingRegressor has had parameter max_features: https://github.com/scikit-learn/scikit-learn/blob/6e9039160/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.py#L1499

This appears to be missing from the stubs: https://github.com/microsoft/python-type-stubs/blob/main/stubs/sklearn/ensemble/_hist_gradient_boosting/gradient_boosting.pyi#L90

debonte commented 5 days ago

Thanks for the issue. We would welcome a PR with a fix.

ara-incom commented 3 days ago

@debonte, I've given it a shot in #323. Let me know if I need to do anything further!

debonte commented 3 days ago

@ara-incom, thanks. I won't be able to look at this until Monday. Just wanted to let you know that I saw it and an not ignoring it.