search

microsoft / qsharp-runtime

Runtime components for Q#
https://docs.microsoft.com/quantum
MIT License
286 stars 93 forks source link

QirRuntime coding style improvements #482

Open kuzminrobin opened 3 years ago

kuzminrobin commented 3 years ago

  1. from https://github.com/microsoft/qsharp-runtime/pull/479/files#r564862295

    #include <assert.h>

    Typically the C++ files do not include the C standard headers directly (#include <assert.h>) but instead the C++ files include the C++-wrappers of those (#include <cassert>).

  2. from https://github.com/microsoft/qsharp-runtime/pull/479/files#r564934984 Switch to using nested namespaces https://github.com/AnthonyCalandra/modern-cpp-features#nested-namespaces

  3. Standardize line endings across all files

  4. Use std::int64_t and consistently #include ? (from https://github.com/microsoft/qsharp-runtime/pull/475/files#r561004734)

bettinaheim commented 3 years ago

Related/similar: https://github.com/microsoft/qsharp-runtime/issues/484