microsoft / qsharp

Azure Quantum Development Kit, including the Q# programming language, resource estimator, and Quantum Katas
https://microsoft.github.io/qsharp/
MIT License
427 stars 86 forks source link

Use \ket and \bra macros instead of \rangle and \langle #1503

Closed tcNickolas closed 4 months ago

tcNickolas commented 4 months ago

Closes #1448.

github-actions[bot] commented 4 months ago

Benchmark for 2cfcca3

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Array append evaluation | 343.7±2.50µs | 341.5±2.24µs | -0.64% | | Array literal evaluation | 197.9±0.38µs | **179.4±1.56µs** | **-9.35%** | | Array update evaluation | 426.0±3.01µs | **421.9±2.23µs** | **-0.96%** | | Core + Standard library compilation | 17.2±0.34ms | 17.0±0.20ms | -1.16% | | Deutsch-Jozsa evaluation | 5.0±0.05ms | 5.0±0.18ms | 0.00% | | Large file parity evaluation | 33.6±0.11ms | 33.7±0.30ms | +0.30% | | Large input file compilation | 11.7±0.17ms | **11.5±0.17ms** | **-1.71%** | | Large input file compilation (interpreter) | 45.7±1.15ms | 45.9±1.23ms | +0.44% | | Large nested iteration | 33.9±0.16ms | **33.3±0.31ms** | **-1.77%** | | Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample | 1545.8±40.96µs | 1543.6±31.57µs | -0.14% | | Perform Runtime Capabilities Analysis (RCA) on large file sample | 7.7±0.17ms | 7.7±0.18ms | 0.00% | | Perform Runtime Capabilities Analysis (RCA) on teleport sample | 1409.5±35.45µs | 1414.6±42.56µs | +0.36% | | Perform Runtime Capabilities Analysis (RCA) on the core and std libraries | 27.5±0.20ms | **27.2±0.29ms** | **-1.09%** | | Teleport evaluation | 87.1±4.08µs | 88.2±4.14µs | +1.26% |
billti commented 4 months ago

I can't believe I just looked through every line of that (I didn't realize how big it was when I started 🤣 ). I also spot checked the rendering of some of the trickier changes locally. Great job! I'm sure you automated most of the changes, but there was still some really subtle syntax updates, and I didn't catch a single issue.

I do think the LaTeX is much easier to follow with these commands. Thanks!