microsoft / qsharp

Azure Quantum Development Kit, including the Q# programming language, resource estimator, and Quantum Katas
https://microsoft.github.io/qsharp/
MIT License
367 stars 73 forks source link

[Unitary hack] Add doc for internal AND #1580

Closed Manvi-Agrawal closed 3 weeks ago

Manvi-Agrawal commented 1 month ago

Fixes #1212. image

Manvi-Agrawal commented 1 month ago

@swernli thanks for your review. I have update documentation and updated PR description as per your feedback.

The previous CI run failed on integration test(https://github.com/microsoft/qsharp/actions/runs/9281069142) and it seems unrelated, so I merged latest main.

swernli commented 1 month ago

Looks like the change to the stdlib made some debugger tests fail because they confirm the line number that the debugger breaks into. Since the file contents changed, the line numbers have to be updated. A little annoying but an expected consequence of the change.

Manvi-Agrawal commented 1 month ago

Looks like the change to the stdlib made some debugger tests fail because they confirm the line number that the debugger breaks into. Since the file contents changed, the line numbers have to be updated. A little annoying but an expected consequence of the change.

Thanks @swernli for looking into this. I have updated the failing IT based on CI build failures. Do you know how can I run Q# Debugger Tests suite locally?

swernli commented 1 month ago

To run the integration tests, you should be able to use the same python build script, but pass an additional flag: python build.py --integration-tests

Manvi-Agrawal commented 1 month ago

Thanks @swernli , the integration tests are passing locally for me now.

Manvi-Agrawal commented 1 month ago

@minestarks could you please help with code owner approval

Manvi-Agrawal commented 4 weeks ago

@swernli , @minestarks , @tcNickolas , could you please merge this PR since I have the required approvals.

minestarks commented 4 weeks ago

@Manvi-Agrawal I will merge this PR as soon as the main branch is reopened after our next release (soon)!