Closed minestarks closed 1 week ago
Huh, that's almost certainly not due to these changes since it's in kata validation.
@cesarzc / @tcNickolas I think we may have a flaky kata:
# Subtest: key_distribution kata is valid
not ok 21 - key_distribution kata is valid
---
duration_ms: 97.515708
failureType: 'testCodeFailure'
error: 'Solution "key_distribution__random_array_solution" for exercise "key_distribution__random_array" is incorrect'
code: 'ERR_ASSERTION'
name: 'AssertionError'
expected: true
actual: false
operator: '=='
stack: |-
validateExercise (file:///home/runner/work/qsharp/qsharp/npm/qsharp/test/basics.js:260:7)
async validateKata (file:///home/runner/work/qsharp/qsharp/npm/qsharp/test/basics.js:279:5)
async TestContext.<anonymous> (file:///home/runner/work/qsharp/qsharp/npm/qsharp/test/basics.js:316:5)
async Test.run (node:internal/test_runner/test:574:9)
async Test.processPendingSubtests (node:internal/test_runner/test:318:7)
https://github.com/microsoft/qsharp/actions/runs/9575713105/job/26400994276?pr=1623#step:9:4568
That's interesting, I don't remember it being noisy in the classic katas. I guess we run CI a lot more often in the new repo, so low-probability failures will happen more frequently. I'll take a look at improving this once I'm back.Message ID: @.*** com>
Just re-ran the pipeline so hopefully it won't flake this time.
This is in preparation for the package work, but I think it's a useful refactor in its own right. No behavior changes.
There are quite a few features/commands across the VS Code extension* that are meant to operate on the "currently active Q# project". This is defined as the Q# document in the currently active editor, and if that document is associated with a qsharp.json, the entire project.
This code was duplicated across all these commands, and was slightly different everywhere. There have been bugs where we weren't respecting some of the common settings (e.g. #1565) and changes where we had to update each command separately if we changed something about project semantics (e.g. #1089, #918) . This PR aims to unify all that so we touch fewer places when we change something about the project compiler configuration logic.
*Run, Debug, Circuit, Estimate, Histogram commands, Show Documentation, Get QIR and Submit to Azure.