microsoft / qsharp

Azure Quantum Development Kit, including the Q# programming language, resource estimator, and Quantum Katas
https://microsoft.github.io/qsharp/
MIT License
423 stars 86 forks source link

Controlled rotation gates don't check that target and controls are distinct qubits #1643

Closed swernli closed 3 months ago

swernli commented 3 months ago

Fixes #1339

github-actions[bot] commented 3 months ago

Benchmark for f77a27b

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Array append evaluation | 330.6±5.67µs | 328.3±7.48µs | -0.70% | | Array literal evaluation | 174.8±1.40µs | **169.2±2.16µs** | **-3.20%** | | Array update evaluation | 407.4±5.99µs | 407.7±5.02µs | +0.07% | | Core + Standard library compilation | 20.9±0.80ms | 20.5±0.79ms | -1.91% | | Deutsch-Jozsa evaluation | **5.0±0.05ms** | 5.1±0.04ms | **+2.00%** | | Large file parity evaluation | **33.9±0.28ms** | 34.3±0.52ms | **+1.18%** | | Large input file compilation | 13.2±0.38ms | **12.6±0.37ms** | **-4.55%** | | Large input file compilation (interpreter) | 51.4±1.74ms | **48.1±0.80ms** | **-6.42%** | | Large nested iteration | 32.2±0.29ms | 32.4±1.45ms | +0.62% | | Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample | 1592.9±83.40µs | 1581.1±87.35µs | -0.74% | | Perform Runtime Capabilities Analysis (RCA) on large file sample | 7.9±0.12ms | 7.9±0.13ms | 0.00% | | Perform Runtime Capabilities Analysis (RCA) on teleport sample | 1447.3±92.96µs | 1462.9±144.73µs | +1.08% | | Perform Runtime Capabilities Analysis (RCA) on the core and std libraries | 28.5±0.32ms | 28.2±0.67ms | -1.05% | | Teleport evaluation | 87.8±3.62µs | 88.9±4.25µs | +1.25% |
github-actions[bot] commented 3 months ago

Benchmark for 9274a46

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Array append evaluation | 325.2±1.24µs | 324.0±3.37µs | -0.37% | | Array literal evaluation | **174.4±1.85µs** | 185.9±0.51µs | **+6.59%** | | Array update evaluation | 406.5±2.70µs | 405.0±2.77µs | -0.37% | | Core + Standard library compilation | 22.8±1.00ms | 22.2±0.70ms | -2.63% | | Deutsch-Jozsa evaluation | 5.1±0.06ms | 5.1±0.13ms | 0.00% | | Large file parity evaluation | 34.4±0.15ms | **34.0±0.25ms** | **-1.16%** | | Large input file compilation | 14.3±0.44ms | **13.6±0.54ms** | **-4.90%** | | Large input file compilation (interpreter) | 53.4±2.04ms | **51.6±1.34ms** | **-3.37%** | | Large nested iteration | 32.5±0.87ms | 32.2±0.72ms | -0.92% | | Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample | 1590.1±82.02µs | 1596.3±159.78µs | +0.39% | | Perform Runtime Capabilities Analysis (RCA) on large file sample | 8.1±0.29ms | 8.0±0.13ms | -1.23% | | Perform Runtime Capabilities Analysis (RCA) on teleport sample | 1443.9±62.23µs | 1445.6±73.20µs | +0.12% | | Perform Runtime Capabilities Analysis (RCA) on the core and std libraries | 28.7±0.27ms | 28.8±0.89ms | +0.35% | | Teleport evaluation | 91.6±5.21µs | 89.2±3.98µs | -2.62% |
github-actions[bot] commented 3 months ago

Benchmark for b245a3b

Click to view benchmark | Test | Base | PR | % | |------|--------------|------------------|---| | Array append evaluation | 326.6±1.54µs | 326.4±1.61µs | -0.06% | | Array literal evaluation | 192.6±1.02µs | **186.2±0.63µs** | **-3.32%** | | Array update evaluation | 405.1±1.34µs | 406.2±1.71µs | +0.27% | | Core + Standard library compilation | 21.2±0.60ms | 21.0±0.62ms | -0.94% | | Deutsch-Jozsa evaluation | **5.1±0.05ms** | 5.2±0.05ms | **+1.96%** | | Large file parity evaluation | 34.2±0.19ms | 34.1±0.24ms | -0.29% | | Large input file compilation | 13.3±0.41ms | **13.0±0.28ms** | **-2.26%** | | Large input file compilation (interpreter) | 51.9±1.20ms | **50.7±1.18ms** | **-2.31%** | | Large nested iteration | 32.3±0.42ms | 32.2±0.25ms | -0.31% | | Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample | 1578.3±78.23µs | 1585.4±78.38µs | +0.45% | | Perform Runtime Capabilities Analysis (RCA) on large file sample | 7.8±0.09ms | 7.8±0.10ms | 0.00% | | Perform Runtime Capabilities Analysis (RCA) on teleport sample | 1446.0±129.09µs | 1432.3±31.34µs | -0.95% | | Perform Runtime Capabilities Analysis (RCA) on the core and std libraries | 28.4±0.24ms | 28.3±0.16ms | -0.35% | | Teleport evaluation | 89.6±3.63µs | 91.3±4.36µs | +1.90% |