Open tcNickolas opened 4 months ago
I just want to mention a couple of arguments in favor of having a function that doesn't include swaps after QFT rotations.
When we started modernizing QDK we wanted to include only minimal functionality. That said, nothing prevents us from having both functions now.
To follow up https://github.com/microsoft/qsharp/pull/1810 and the internal discussion on this: using
ApplyQFT
name for an operation that applies only a part of QFT is misleading and can lead to long and unpleasant debugging sessions. I would suggest renaming it to something likeApplyQFTRotations
, which is a more accurate name, since it accurately describes that only the rotations part of the QFT is applied, and to introduce a new operationApplyQFT
that actually applies a complete QFT.For example, I'm working on the second part of QFT kata, and every task in it includes applying either QFT or Adjoint QFT. We don't have dependencies between kata cells, and we don't have a single operation to apply QFT, so I have to include instructions regarding this in every task. I will run into the same issue when working on the QPE kata, programming assignments that include QFT and QPE, and so on.