microsoft / qsharp

Azure Quantum Development Kit, including the Q# programming language, resource estimator, and Quantum Katas
https://microsoft.github.io/qsharp/
MIT License
438 stars 86 forks source link

[Samples] Investigate redundant Check #1933

Open Manvi-Agrawal opened 3 weeks ago

Manvi-Agrawal commented 3 weeks ago

Is your feature request related to a problem? Please describe. There exists a typescript test that executes samples in samples.mjs (Code link ) . IMO, it would be good to investigate whether it is relevant in the current scenario after this repo has been enhanced for testing efficiency primarily in #1533 #1797. As per my understanding we are now checking for lint and sample execution for all samples, so it might be a good idea to get rid of redundancy.

Describe the solution you'd like A clear and concise description of what you want to happen. Get rid of redundant test if its no longer required.

Describe alternatives you've considered Dont remove the test if its needed.

Additional context

sezna commented 5 days ago

@Manvi-Agrawal Yep, this seems like a redundancy and removing that JS would be practical.