search

microsoft / rag-experiment-accelerator

The RAG Experiment Accelerator is a versatile tool designed to expedite and facilitate the process of conducting experiments and evaluations using Azure Cognitive Search and RAG pattern.
https://github.com/microsoft/rag-experiment-accelerator
Other
192 stars 67 forks source link

PRs from Forks won't have Access to Secrets #452

Open martinpeck opened 7 months ago

martinpeck commented 7 months ago

The GitHub action rag_exp_acc_ci runs on PRs. However, because PRs from forks aren't given secrets, this action will fail for all such PRs.

This project needs to address this if PRs from forks are expected (i.e. any external contribution)

Ways to work around this include the approach taken by Azure TRE where by a PR bot is used to kick of builds of PRs only after inspection of the PR to ensure that secrets won't be exposed:

https://github.com/microsoft/AzureTRE/blob/main/.github/workflows/pr_comment_bot.yml

martinpeck commented 7 months ago

Alternatively, don't run builds that require secrets against PRs. Only run them against branches, once merged