search

microsoft / react-native-adaptivecards

React Native renderer for AdaptiveCards
https://microsoft.github.io/react-native-adaptivecards/
80 stars 21 forks source link

Improve example project, move some things to peerDependencies #24

Closed brentvatne closed 4 years ago

brentvatne commented 5 years ago

Hello! I saw a session at Microsoft Build about AdaptiveCards and stumbled upon this repo. I found the example wasn't running on my machine out of the box because Checkbox.js was renamed to CheckBox.js at some point and git is quite bad at case change in renamed files (see this). I also noticed that it was necessary to run a special command to get the example running.

This PR does a few things:

  1. Consumes source directly from the parent directory so it's easy to make changes and see them immediately in the example, without running some other process to build code to the example directory
  2. Moves react-native-vector-icons to peerDependencies
  3. The main file for react-native points to src/index.ts now - this makes (1) easier and also if developers run into some problems when using the library it's easier for them to debug in node_modules directly. React Native's packager strips TypeScript types out of the box now so this works fine.
  4. Updated the example to use Expo SDK 32.
  5. Updated the README in the examples directory
msftclas commented 5 years ago

CLA assistant check
All CLA requirements met.

brentvatne commented 5 years ago

Sorry for the massive diff, it's mostly because I deleted the generated files in the examples directory and re-created the yarn lockfiles!

brentvatne commented 4 years ago

closing because it looks like things have moved on since the pr was opened (lots of changes to the updated files, not worth rebasing), no worries :)